Skip to content

Hard-code OpenSearch dependency to 1.1.0#248

Merged
peterzhuamazon merged 2 commits intoopensearch-project:1.1from
dblock:1.1.1-fixes
Dec 8, 2021
Merged

Hard-code OpenSearch dependency to 1.1.0#248
peterzhuamazon merged 2 commits intoopensearch-project:1.1from
dblock:1.1.1-fixes

Conversation

@dblock
Copy link
Copy Markdown
Member

@dblock dblock commented Dec 8, 2021 •
edited
Loading

Signed-off-by: dblock dblock@dblock.org

Description

In thinking about how to fix opensearch-project/opensearch-build#1266 this is another alternative to #249. Since there's no opensearch-min 1.1.1 the patch for dashboards-reports uses 1.1.0 build tools.

Issues Resolved

opensearch-project/opensearch-build#1266

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Hard-code the dependency on OpenSearch 1.1.0.
cd7418f 
Signed-off-by: dblock <dblock@dblock.org>
This was referenced Dec 8, 2021
Closed
Closed
@dblock
Copy link
Copy Markdown
Member Author

dblock commented Dec 8, 2021

@peterzhuamazon which one do you prefer?

@dblock dblock marked this pull request as ready for review December 8, 2021 18:10
@dblock
Copy link
Copy Markdown
Member Author

dblock commented Dec 8, 2021

I am not sure how to resolve the dashboards build failure, help? /cc: @kavilla

zhongnansu
zhongnansu previously approved these changes Dec 8, 2021
View reviewed changes
@davidcui1225
Copy link
Copy Markdown
Contributor

davidcui1225 commented Dec 8, 2021

I am not sure how to resolve the dashboards build failure, help? /cc: @kavilla

I think that failure was fixed by a PR yesterday that was merged to the main branch but not 1.1, is that correct @joshuali925

@peterzhuamazon
Copy link
Copy Markdown
Member

peterzhuamazon commented Dec 8, 2021

I am not sure how to resolve the dashboards build failure, help? /cc: @kavilla

I think that failure was fixed by a PR yesterday that was merged to the main branch but not 1.1, is that correct @joshuali925

That is most likely caused by apt not updated.

@joshuali925 @dblock
Fix apt source and link checker for CI (opensearch-project#245)
f6ff002 
* Update apt source in CI

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Try fix link checker

Signed-off-by: Joshua Li <joshuali925@gmail.com>
@zhongnansu
Copy link
Copy Markdown
Member

zhongnansu commented Dec 8, 2021

I am not sure how to resolve the dashboards build failure, help? /cc: @kavilla

I think that failure was fixed by a PR yesterday that was merged to the main branch but not 1.1, is that correct @joshuali925

I am not sure how to resolve the dashboards build failure, help? /cc: @kavilla

apt update command is added in this PR to main #245

@dblock
Copy link
Copy Markdown
Member Author

dblock commented Dec 8, 2021

cherry-picked 9f4fb7b on top of this

peterzhuamazon
peterzhuamazon approved these changes Dec 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@peterzhuamazon peterzhuamazon merged commit d33924f into opensearch-project:1.1 Dec 8, 2021
@dblock dblock deleted the 1.1.1-fixes branch December 8, 2021 21:53
kavilla pushed a commit to kavilla/dashboards-reports that referenced this pull request Jul 12, 2023
@zhongnansu
Add codecov for kibana reports & Add README badges (opensearch-projec…
40ff7ec 
…t#248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshuali925 joshuali925 joshuali925 approved these changes

@peterzhuamazon peterzhuamazon peterzhuamazon approved these changes

@davidcui1225 davidcui1225 Awaiting requested review from davidcui1225

+1 more reviewer

@zhongnansu zhongnansu zhongnansu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dblock @davidcui1225 @peterzhuamazon @zhongnansu @joshuali925