Hard-code OpenSearch dependency to 1.1.0 (alternative)#249
Closed
dblock wants to merge 2 commits intoopensearch-project:1.1from
Closed
Hard-code OpenSearch dependency to 1.1.0 (alternative)#249dblock wants to merge 2 commits intoopensearch-project:1.1from
dblock wants to merge 2 commits intoopensearch-project:1.1from
Conversation
Signed-off-by: dblock <dblock@dblock.org>
Signed-off-by: dblock <dblock@dblock.org>
This was referenced Dec 8, 2021
Codecov Report
@@ Coverage Diff @@
## 1.1 #249 +/- ##
=============================================
- Coverage 64.15% 53.42% -10.74%
Complexity 309 309
=============================================
Files 102 69 -33
Lines 4383 2454 -1929
Branches 658 277 -381
=============================================
- Hits 2812 1311 -1501
+ Misses 1403 978 -425
+ Partials 168 165 -3
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Member
Author
|
@peterzhuamazon which one do you prefer? |
Member
|
Closed because: opensearch-project/opensearch-build#1266 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock dblock@dblock.org
Description
In thinking about how to fix opensearch-project/opensearch-build#1266 this is another alternative to #248.
Issues Resolved
opensearch-project/opensearch-build#1266
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.