Added query for initialized extensions by mloufra · Pull Request #300 · opensearch-project/opensearch-sdk-java

mloufra · 2022-12-28T17:48:44Z

Signed-off-by: Frank Lou mloufra@amazon.com

Description

Create a feature to have an extension query to OpenSearch to obtain a list of initialized extensions and determine whether a particular extension is initialized.
Equivalent PR on OpenSearch : ~~opensearch-project/OpenSearch#5628~~ opensearch-project/OpenSearch#5658

Issues Resolved

fixes #149

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

src/main/java/org/opensearch/sdk/ExtensionsRunner.java

src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java

src/main/java/org/opensearch/sdk/ExtensionsRunner.java

dbwiddis

LGTM (pending merge of #5658 and passing tests)

src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java

src/main/java/org/opensearch/sdk/ExtensionsRunner.java

src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java

owaiskazi19 · 2023-01-03T14:15:28Z

Run spotless to fix the build errors:

> Task :spotlessJava
FAILURE: Build failed with an exception.
> Task :spotlessJavaCheck FAILED

Signed-off-by: Frank Lou <mloufra@amazon.com>

src/main/java/org/opensearch/sdk/ExtensionsRunner.java

src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java

Signed-off-by: Frank Lou <mloufra@amazon.com>

codecov-commenter · 2023-01-09T19:07:45Z

Codecov Report

Merging #300 (fff3446) into main (4555529) will decrease coverage by 3.56%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #300      +/-   ##
============================================
- Coverage     73.22%   69.66%   -3.57%     
  Complexity      117      117              
============================================
  Files            25       26       +1     
  Lines           508      534      +26     
  Branches         15       15              
============================================
  Hits            372      372              
- Misses          128      154      +26     
  Partials          8        8

Impacted Files	Coverage Δ
...main/java/org/opensearch/sdk/ExtensionsRunner.java	`65.77% <0.00%> (-4.74%)`	⬇️
...k/handlers/ExtensionDependencyResponseHandler.java	`0.00% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

* query for initialized extensions Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * apply spotless Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * add javadoc Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> Signed-off-by: Frank Lou <mloufra@amazon.com>

mloufra requested review from CEHENKLE, dbwiddis, joshpalis, owaiskazi19, ryanbogan and saratvemulapalli as code owners December 28, 2022 17:48

mloufra mentioned this pull request Dec 28, 2022

[Feature/extensions]Added query for initialized extensions opensearch-project/OpenSearch#5628

Closed

6 tasks

ryanbogan reviewed Dec 28, 2022

View reviewed changes

src/main/java/org/opensearch/sdk/ExtensionsRunner.java Outdated Show resolved Hide resolved

ryanbogan reviewed Dec 28, 2022

View reviewed changes

src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java Outdated Show resolved Hide resolved

mloufra force-pushed the query-for-initialized-extensions branch from b2f073e to eb90621 Compare December 28, 2022 19:40

dbwiddis requested changes Dec 28, 2022

View reviewed changes

mloufra requested a review from dbwiddis December 29, 2022 18:38

mloufra mentioned this pull request Dec 29, 2022

[Extensions]Add query for initialized extensions opensearch-project/OpenSearch#5658

Merged

6 tasks

dbwiddis previously approved these changes Dec 30, 2022

View reviewed changes

mloufra dismissed dbwiddis’s stale review via d7eb3e4 December 30, 2022 21:34

dbwiddis previously approved these changes Dec 30, 2022

View reviewed changes

dbwiddis requested a review from ryanbogan December 30, 2022 21:40

ryanbogan reviewed Dec 30, 2022

View reviewed changes

src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java Outdated Show resolved Hide resolved

ryanbogan reviewed Dec 30, 2022

View reviewed changes

src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java Outdated Show resolved Hide resolved

mloufra dismissed dbwiddis’s stale review via 74a3280 December 30, 2022 21:53

mloufra requested a review from ryanbogan December 30, 2022 21:56

dbwiddis requested changes Dec 30, 2022

View reviewed changes

src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java Outdated Show resolved Hide resolved

src/main/java/org/opensearch/sdk/ExtensionsRunner.java Show resolved Hide resolved

mloufra requested a review from dbwiddis December 30, 2022 23:40

owaiskazi19 reviewed Jan 3, 2023

View reviewed changes

src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java Outdated Show resolved Hide resolved

owaiskazi19 reviewed Jan 3, 2023

View reviewed changes

src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java Outdated Show resolved Hide resolved

dbwiddis mentioned this pull request Jan 5, 2023

[FEATURE] Let an extension query OpenSearch for all initialized extensions #149

Closed

mloufra requested a review from owaiskazi19 January 5, 2023 23:02

mloufra added 2 commits January 5, 2023 23:07

query for initialized extensions

a4dc8ae

Signed-off-by: Frank Lou <mloufra@amazon.com>

address comment

c0428f0

Signed-off-by: Frank Lou <mloufra@amazon.com>

mloufra added 6 commits January 5, 2023 23:07

address comment

e2e25d1

Signed-off-by: Frank Lou <mloufra@amazon.com>

apply spotless

d8f1bf6

Signed-off-by: Frank Lou <mloufra@amazon.com>

address comment

d8efe09

Signed-off-by: Frank Lou <mloufra@amazon.com>

address comment

205c3b0

Signed-off-by: Frank Lou <mloufra@amazon.com>

address comment

29152d7

Signed-off-by: Frank Lou <mloufra@amazon.com>

address comment

49f77dd

Signed-off-by: Frank Lou <mloufra@amazon.com>

mloufra force-pushed the query-for-initialized-extensions branch from 8d061db to 49f77dd Compare January 5, 2023 23:08

mloufra added 8 commits January 5, 2023 23:49

address comment

be073ff

Signed-off-by: Frank Lou <mloufra@amazon.com>

address comment

3a6ced3

Signed-off-by: Frank Lou <mloufra@amazon.com>

address comment

c96f432

Signed-off-by: Frank Lou <mloufra@amazon.com>

address comment

c5d022c

Signed-off-by: Frank Lou <mloufra@amazon.com>

address comment

9bb5ae5

Signed-off-by: Frank Lou <mloufra@amazon.com>

address comment

f6993ac

Signed-off-by: Frank Lou <mloufra@amazon.com>

address comment

bd2f775

Signed-off-by: Frank Lou <mloufra@amazon.com>

add javadoc

4c13265

Signed-off-by: Frank Lou <mloufra@amazon.com>

dbwiddis requested changes Jan 6, 2023

View reviewed changes

src/main/java/org/opensearch/sdk/ExtensionsRunner.java Outdated Show resolved Hide resolved

src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java Outdated Show resolved Hide resolved

mloufra added 2 commits January 7, 2023 00:27

address comment

c04ef39

Signed-off-by: Frank Lou <mloufra@amazon.com>

address comment

3aa77b8

Signed-off-by: Frank Lou <mloufra@amazon.com>

mloufra requested a review from dbwiddis January 9, 2023 18:03

address comment

fff3446

Signed-off-by: Frank Lou <mloufra@amazon.com>

dbwiddis approved these changes Jan 9, 2023

View reviewed changes

ryanbogan approved these changes Jan 10, 2023

View reviewed changes

mloufra merged commit c7c2d87 into opensearch-project:main Jan 10, 2023

mloufra deleted the query-for-initialized-extensions branch January 10, 2023 17:15

ryanbogan mentioned this pull request Jan 14, 2023

[Backport 2.x] Add query for initialized extensions opensearch-project/OpenSearch#5861

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added query for initialized extensions#300

Added query for initialized extensions#300
mloufra merged 19 commits intoopensearch-project:mainfrom
mloufra:query-for-initialized-extensions

mloufra commented Dec 28, 2022 •

edited by dbwiddis

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dbwiddis left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

owaiskazi19 commented Jan 3, 2023

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Jan 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

mloufra commented Dec 28, 2022 • edited by dbwiddis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dbwiddis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

owaiskazi19 commented Jan 3, 2023

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Jan 9, 2023

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mloufra commented Dec 28, 2022 •

edited by dbwiddis

Loading