[Extensions]Add query for initialized extensions#5658
Merged
owaiskazi19 merged 13 commits intoopensearch-project:mainfrom Jan 5, 2023
Merged
[Extensions]Add query for initialized extensions#5658owaiskazi19 merged 13 commits intoopensearch-project:mainfrom
owaiskazi19 merged 13 commits intoopensearch-project:mainfrom
Conversation
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
dbwiddis
requested changes
Dec 29, 2022
Member
dbwiddis
left a comment
There was a problem hiding this comment.
Great progress. A few more tweaks needed.
| } | ||
|
|
||
| public ExtensionRequest(StreamInput in) throws IOException { | ||
| super(in); |
Member
There was a problem hiding this comment.
I believe Requests require the super(in) while responses do not. This should definitely match the writeTo implementation; I don't expect it will pass tests without it matching.
| this(requestType, null); | ||
| } | ||
|
|
||
| public ExtensionRequest(ExtensionsManager.RequestType requestType, Optional<String> uniqueId) { |
Member
There was a problem hiding this comment.
Don't make the user provide an optional. Just take a @Nullable String parameter here, and then set this.uniqueId the same way you do in the stream constructor. Given the overloaded constructor above, this would set the optional to null and break things later.
| if (o == null || getClass() != o.getClass()) return false; | ||
| ExtensionRequest that = (ExtensionRequest) o; | ||
| return Objects.equals(requestType, that.requestType); | ||
| return Objects.equals(requestType, that.requestType) && uniqueId.equals(that.uniqueId); |
Member
There was a problem hiding this comment.
(Style) use the same comparison format (either Objects.equals() or direct equals comparison) for both.
| private static final Logger logger = LogManager.getLogger(ExtensionRequest.class); | ||
| private ExtensionsManager.RequestType requestType; | ||
| private final ExtensionsManager.RequestType requestType; | ||
| private final Optional<String> uniqueId; |
Member
There was a problem hiding this comment.
It looks like there is no test class for ExtensionRequest so you should create one and include a test of this uniqueID, both in the null case (single arg constructor) or value present case (two arg constructor)
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #5658 +/- ##
============================================
- Coverage 70.98% 70.97% -0.02%
- Complexity 58669 58685 +16
============================================
Files 4763 4765 +2
Lines 279945 280009 +64
Branches 40418 40430 +12
============================================
+ Hits 198731 198738 +7
- Misses 64988 65084 +96
+ Partials 16226 16187 -39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
owaiskazi19
reviewed
Jan 4, 2023
server/src/main/java/org/opensearch/extensions/DiscoveryExtensionNode.java
Outdated
Show resolved
Hide resolved
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Member
|
@mloufra can you resolve conflicts with changelog.md? |
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
cc87d2a to
cc1f2d9
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
owaiskazi19
approved these changes
Jan 5, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5658-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e24de72df5cc1ae7a44f84e216518b916f0c7cf5
# Push it to GitHub
git push --set-upstream origin backport/backport-5658-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
6 tasks
2 tasks
andrross
reviewed
Jan 19, 2023
| - Add support for ppc64le architecture ([#5459](https://github.com/opensearch-project/OpenSearch/pull/5459)) | ||
| - Added @gbbafna as an OpenSearch maintainer ([#5668](https://github.com/opensearch-project/OpenSearch/pull/5668)) | ||
| - Added support for feature flags in opensearch.yml ([#4959](https://github.com/opensearch-project/OpenSearch/pull/4959)) | ||
| - Add query for initialized extensions ([#5658](https://github.com/opensearch-project/OpenSearch/pull/5658)) |
Member
There was a problem hiding this comment.
@owaiskazi19 Just a heads up, but since this change was to be backported and released in 2.x, this changelog entry should have gone in the [Unreleased 2.x] section of this file. I'm working on cleaning up the changelog on main right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frank Lou mloufra@amazon.com
Description
Create a feature to have an extension query to OpenSearch to obtain a list of initialized extensions and determine whether a particular extension is initialized.
Equivalent PR on OpenSearch-sdk-java : opensearch-project/opensearch-sdk-java#300
Issues Resolved
fixes opensearch-project/opensearch-sdk-java#149
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.