address comment

mloufra · mloufra · commit cc1f2d95bc08 · 2023-01-04T22:24:28.000Z
Signed-off-by: Frank Lou &lt;mloufra@amazon.com&gt;
diff --git a/server/src/main/java/org/opensearch/extensions/DiscoveryExtensionNode.java b/server/src/main/java/org/opensearch/extensions/DiscoveryExtensionNode.java
@@ -84,8 +84,10 @@ public List<ExtensionDependency> getDependencies() {
 
     public boolean dependenciesContain(ExtensionDependency dependency) {
         for (ExtensionDependency extensiondependency : this.dependencies) {
-            return dependency.getUniqueId().equals(extensiondependency.getUniqueId())
-                && dependency.getVersion().equals(extensiondependency.getVersion());
+            if (dependency.getUniqueId().equals(extensiondependency.getUniqueId())
+                && dependency.getVersion().equals(extensiondependency.getVersion())) {
+                return true;
+            }
         }
         return false;
     }

Original file line number	Diff line number	Diff line change
`@@ -84,8 +84,10 @@ public List<ExtensionDependency> getDependencies() {`
`84`	`84`
`85`	`85`	`public boolean dependenciesContain(ExtensionDependency dependency) {`
`86`	`86`	`for (ExtensionDependency extensiondependency : this.dependencies) {`
`87`		`- return dependency.getUniqueId().equals(extensiondependency.getUniqueId())`
`88`		`- && dependency.getVersion().equals(extensiondependency.getVersion());`
	`87`	`+ if (dependency.getUniqueId().equals(extensiondependency.getUniqueId())`
	`88`	`+ && dependency.getVersion().equals(extensiondependency.getVersion())) {`
	`89`	`+ return true;`
	`90`	`+ }`
`89`	`91`	`}`
`90`	`92`	`return false;`
`91`	`93`	`}`