Return consumed params and content from extensions#187
Merged
dbwiddis merged 7 commits intoopensearch-project:mainfrom Oct 12, 2022
Merged
Return consumed params and content from extensions#187dbwiddis merged 7 commits intoopensearch-project:mainfrom
dbwiddis merged 7 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
…ava into response
owaiskazi19
approved these changes
Oct 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
============================================
- Coverage 69.00% 66.94% -2.06%
- Complexity 100 103 +3
============================================
Files 25 24 -1
Lines 442 475 +33
Branches 13 25 +12
============================================
+ Hits 305 318 +13
- Misses 129 141 +12
- Partials 8 16 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
…t#187) * Remove duplicate copies of registries in handlers Signed-off-by: Daniel Widdis <widdis@gmail.com> * Move ExtensionRestResponse to OpenSearch Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add a POST request to parse content Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add a DELETE request corresponding to the POST Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add consumed params and content to Extension Responses Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update tests and OpenAPI spec Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com>
caokyhieu
pushed a commit
to caokyhieu/opensearch-sdk-java
that referenced
this pull request
Aug 15, 2025
…t#187) * Remove duplicate copies of registries in handlers Signed-off-by: Daniel Widdis <widdis@gmail.com> * Move ExtensionRestResponse to OpenSearch Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add a POST request to parse content Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add a DELETE request corresponding to the POST Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add consumed params and content to Extension Responses Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update tests and OpenAPI spec Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR: opensearch-project/OpenSearch#4705
This is a resubmit of PR #169 which was previously merged but lost in a force push.
Description
Moves the
ExtensionRestResponseclass from the SDK too.o.extensions.rest.ExtensionRestRequestHandlerto copy the new fieldsPOSTandDELETEmethods to the Hello World sample and updated openapi specIssues Resolved
Fixes #165
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.