Return consumed params and content from extensions#169
Merged
dbwiddis merged 7 commits intoopensearch-project:mainfrom Oct 10, 2022
Merged
Return consumed params and content from extensions#169dbwiddis merged 7 commits intoopensearch-project:mainfrom
dbwiddis merged 7 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
6 tasks
owaiskazi19
reviewed
Oct 10, 2022
src/main/java/org/opensearch/sdk/sample/helloworld/rest/RestHelloAction.java
Show resolved
Hide resolved
…ava into response
owaiskazi19
pushed a commit
that referenced
this pull request
Oct 12, 2022
* Remove duplicate copies of registries in handlers Signed-off-by: Daniel Widdis <widdis@gmail.com> * Move ExtensionRestResponse to OpenSearch Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add a POST request to parse content Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add a DELETE request corresponding to the POST Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add consumed params and content to Extension Responses Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update tests and OpenAPI spec Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
dbwiddis
added a commit
that referenced
this pull request
Oct 12, 2022
* Remove duplicate copies of registries in handlers Signed-off-by: Daniel Widdis <widdis@gmail.com> * Move ExtensionRestResponse to OpenSearch Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add a POST request to parse content Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add a DELETE request corresponding to the POST Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add consumed params and content to Extension Responses Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update tests and OpenAPI spec Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
dbwiddis
added a commit
that referenced
this pull request
Oct 12, 2022
* Remove duplicate copies of registries in handlers Signed-off-by: Daniel Widdis <widdis@gmail.com> * Move ExtensionRestResponse to OpenSearch Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add a POST request to parse content Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add a DELETE request corresponding to the POST Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add consumed params and content to Extension Responses Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update tests and OpenAPI spec Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
dbwiddis
added a commit
that referenced
this pull request
Oct 12, 2022
* Added createComponent to Extension interface and created BaseExtension abstract class Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Fixed minor error Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Changed create component arguments Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Addressed PR Comments Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Fixed minor errors Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Return consumed params and content from extensions (#169) * Remove duplicate copies of registries in handlers Signed-off-by: Daniel Widdis <widdis@gmail.com> * Move ExtensionRestResponse to OpenSearch Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add a POST request to parse content Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add a DELETE request corresponding to the POST Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add consumed params and content to Extension Responses Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update tests and OpenAPI spec Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fixed minor errors Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Addressed PR Comments Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Daniel Widdis <widdis@gmail.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
* Added createComponent to Extension interface and created BaseExtension abstract class Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Fixed minor error Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Changed create component arguments Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Addressed PR Comments Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Fixed minor errors Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Return consumed params and content from extensions (opensearch-project#169) * Remove duplicate copies of registries in handlers Signed-off-by: Daniel Widdis <widdis@gmail.com> * Move ExtensionRestResponse to OpenSearch Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add a POST request to parse content Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add a DELETE request corresponding to the POST Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add consumed params and content to Extension Responses Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update tests and OpenAPI spec Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fixed minor errors Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Addressed PR Comments Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Daniel Widdis <widdis@gmail.com>
caokyhieu
pushed a commit
to caokyhieu/opensearch-sdk-java
that referenced
this pull request
Aug 15, 2025
* Added createComponent to Extension interface and created BaseExtension abstract class Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Fixed minor error Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Changed create component arguments Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Addressed PR Comments Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Fixed minor errors Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Return consumed params and content from extensions (opensearch-project#169) * Remove duplicate copies of registries in handlers Signed-off-by: Daniel Widdis <widdis@gmail.com> * Move ExtensionRestResponse to OpenSearch Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add a POST request to parse content Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add a DELETE request corresponding to the POST Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add consumed params and content to Extension Responses Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update tests and OpenAPI spec Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fixed minor errors Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Addressed PR Comments Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Daniel Widdis <widdis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR: opensearch-project/OpenSearch#4705
Note: Gradle check will fail on this repo until the companion PR is merged due to these changes. Passes locally if companion PR changes are published locally.
Description
Moves the
ExtensionRestResponseclass from the SDK too.o.extensions.rest.ExtensionRestRequestHandlerto copy the new fieldsPOSTandDELETEmethods to the Hello World sample and updated openapi specIssues Resolved
Fixes #165
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.