Register REST API and forward REST requests to associated extension#101
Merged
dbwiddis merged 8 commits intoopensearch-project:mainfrom Aug 30, 2022
Merged
Register REST API and forward REST requests to associated extension#101dbwiddis merged 8 commits intoopensearch-project:mainfrom
dbwiddis merged 8 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
5 tasks
Signed-off-by: Daniel Widdis <widdis@gmail.com>
into restController
Member
Author
|
@saratvemulapalli @owaiskazi19 ready for review. Failing gradle check due to changes on companion PR; passes locally after publishToMavenLocal of the companion PR. |
Signed-off-by: Daniel Widdis <widdis@gmail.com>
owaiskazi19
reviewed
Aug 26, 2022
owaiskazi19
reviewed
Aug 26, 2022
Signed-off-by: Daniel Widdis <widdis@gmail.com>
saratvemulapalli
approved these changes
Aug 26, 2022
Member
saratvemulapalli
left a comment
There was a problem hiding this comment.
Thanks @dbwiddis for the changes!
owaiskazi19
approved these changes
Aug 26, 2022
Member
owaiskazi19
left a comment
There was a problem hiding this comment.
LGTM! Thanks for accommodating changes in DESIGN.md
into restController Signed-off-by: Daniel Widdis <widdis@gmail.com>
joshpalis
approved these changes
Aug 29, 2022
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
…pensearch-project#101) * Forward REST requests from OpenSearch to Extension Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update DESIGN Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove nodeId from Rest API request Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add tests Signed-off-by: Daniel Widdis <widdis@gmail.com> * Log full response string Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update DESIGN doc for clarity based on code review Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com>
caokyhieu
pushed a commit
to caokyhieu/opensearch-sdk-java
that referenced
this pull request
Aug 15, 2025
…pensearch-project#101) * Forward REST requests from OpenSearch to Extension Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update DESIGN Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove nodeId from Rest API request Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add tests Signed-off-by: Daniel Widdis <widdis@gmail.com> * Log full response string Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update DESIGN doc for clarity based on code review Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR: opensearch-project/OpenSearch#4282
Description
This and the companion PR linked above completes the work begun in #74 by registering the received API with the
RestController. When OpenSearch receives aRestRequestmatching one of these registered routes, it forwards it to the appropriate extension for further action.See the design schematic and description in #64
Issues Resolved
Closes #64, Closes #69, and Closes #70
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.