[Feature/extensions] Provide Extension API to OpenSearch by dbwiddis · Pull Request #4100 · opensearch-project/OpenSearch

dbwiddis · 2022-08-02T21:55:36Z

Signed-off-by: Daniel Widdis widdis@gmail.com

Description

Companion PR: opensearch-project/opensearch-sdk-java#74

Extensions will report their APIs to the ExtensionsOrchestrator upon initial registration and potentially later in the Extension's lifecycle. These APIs will be registered and mapped so that when Users submit API requests they can be forwarded to the appropriate extensions.

This PR handles the communication of the REST API from the Extension to OpenSearch. Future PRs will complete the process of registering the REST Handlers and redirecting inbound requests.

Issues Resolved

Fixes opensearch-project/opensearch-sdk-java#68

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2022-08-02T22:15:58Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1315/
CommitID: 6aeb8feffe994525154a8e47c82d8cc4ae0f7c30

github-actions · 2022-08-03T04:45:39Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1328/
CommitID: c756aa1628f27c31e3bf9e6190b6f3d5f7617990

github-actions · 2022-08-03T05:05:47Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1329/
CommitID: 956178fd1dcc85c916826eba2cc6fc145533385e

github-actions · 2022-08-03T05:20:21Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1333/
CommitID: f369987e5bfbd02a75288229c4b0c67db2073bcd

github-actions · 2022-08-03T05:29:35Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1336/
CommitID: a31ab795f89fe8e24df9b988f6bd15144f46deec

github-actions · 2022-08-03T05:37:49Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1337/
CommitID: 728e376eb75bad57bfa6a1e1eff759da81220019

github-actions · 2022-08-04T04:14:04Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1423/
CommitID: 7cd912676dd420376904bfad0aa48900a2c3a948

github-actions · 2022-08-04T16:36:51Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1448/
CommitID: 534f97641b91da456d9242597cdb1d0a77b5e8d7

github-actions · 2022-08-04T17:19:56Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1450/
CommitID: 3a7f564c2b0474fbc9dafd6a8c85e68fb76c8d68

Signed-off-by: Daniel Widdis <widdis@gmail.com>

server/src/main/java/org/opensearch/extensions/ExtensionsOrchestrator.java

github-actions · 2022-08-18T22:17:15Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1909/
CommitID: 4cbd4b27d7e15f5bf2828add10ede0382f8cbbbc

owaiskazi19 · 2022-08-18T22:27:20Z

Precommit failing

> Task :server:compileJava
/home/runner/work/OpenSearch/OpenSearch/server/src/main/java/org/opensearch/extensions/ExtensionsOrchestrator.java:232: error: cannot find symbol
                    extensionsList.add(de);
                                       ^
  symbol:   variable de
  location: class ExtensionsOrchestrator
/home/runner/work/OpenSearch/OpenSearch/server/src/main/java/org/opensearch/extensions/ExtensionsOrchestrator.java:233: error: cannot find symbol
                    extensionIdMap.put(extension.getUniqueId(), de);
                                                                ^
  symbol:   variable de

Signed-off-by: Daniel Widdis <widdis@gmail.com>

…enSearch into registerApi

github-actions · 2022-08-18T23:31:40Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1910/
CommitID: d3a2560

github-actions · 2022-08-18T23:33:38Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1911/
CommitID: 3794d6a

owaiskazi19

Comments will be addressed in the follow up PR.

github-actions · 2022-08-18T23:48:17Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1912/
CommitID: 3794d6a

github-actions · 2022-08-19T01:06:17Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1913/
CommitID: 3794d6a

github-actions · 2022-08-19T01:34:19Z

Gradle Check (Jenkins) Run Completed with:

RESULT: ❌
URL:
CommitID: 3794d6a

github-actions · 2022-08-19T04:19:51Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1919/
CommitID: 3794d6a

Signed-off-by: Daniel Widdis <widdis@gmail.com>

…rch-project#4258) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

…nto registerApi

github-actions · 2022-08-19T16:36:24Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1939/
CommitID: 156dc9d

github-actions · 2022-08-19T17:07:29Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1940/
CommitID: 156dc9d

github-actions · 2022-08-19T17:44:58Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1941/
CommitID: 156dc9d

…rch-project#4258) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Daniel Widdis <widdis@gmail.com>

…isterApi

github-actions · 2022-08-19T22:29:53Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1952/
CommitID: 4e75c43

dbwiddis mentioned this pull request Aug 2, 2022

Provide Extension API to OpenSearch opensearch-project/opensearch-sdk-java#74

Merged

dbwiddis changed the title ~~[Feature/Extensions] Provide Extension API to OpenSearch~~ [Feature/extensions] Provide Extension API to OpenSearch Aug 2, 2022

dbwiddis force-pushed the registerApi branch from c756aa1 to 956178f Compare August 3, 2022 04:44

dbwiddis assigned owaiskazi19 and saratvemulapalli and unassigned owaiskazi19 and saratvemulapalli Aug 3, 2022

dbwiddis requested review from owaiskazi19, ryanbogan and saratvemulapalli August 3, 2022 04:59

dbwiddis force-pushed the registerApi branch from a31ab79 to 728e376 Compare August 3, 2022 05:16

dbwiddis marked this pull request as ready for review August 3, 2022 05:26

dbwiddis requested review from a team and reta as code owners August 3, 2022 05:26

dbwiddis marked this pull request as draft August 4, 2022 17:28

dbwiddis marked this pull request as ready for review August 4, 2022 19:50

joshpalis self-requested a review August 4, 2022 20:46

dbwiddis added 4 commits August 4, 2022 13:50

Provide Extension API to OpenSearch

99b4f91

Signed-off-by: Daniel Widdis <widdis@gmail.com>

Add tests

8a9ba72

Signed-off-by: Daniel Widdis <widdis@gmail.com>

Add javadocs

18d5d8e

Signed-off-by: Daniel Widdis <widdis@gmail.com>

Add parsing of API requests

5972dc4

Signed-off-by: Daniel Widdis <widdis@gmail.com>

owaiskazi19 reviewed Aug 18, 2022

View reviewed changes

server/src/main/java/org/opensearch/extensions/ExtensionsOrchestrator.java Show resolved Hide resolved

More verbose variable name

d3a2560

Signed-off-by: Daniel Widdis <widdis@gmail.com>

dbwiddis force-pushed the registerApi branch from 4cbd4b2 to d3a2560 Compare August 18, 2022 22:37

Merge branch 'feature/extensions' of github.com:opensearch-project/Op…

3794d6a

…enSearch into registerApi

owaiskazi19 approved these changes Aug 18, 2022

View reviewed changes

dbwiddis and others added 2 commits August 19, 2022 09:08

Fix license header

a52a158

Signed-off-by: Daniel Widdis <widdis@gmail.com>

Fixing NodeGatewayStartedShards bwc (de)serialization issues (opensea…

6edb549

…rch-project#4258) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

joshpalis approved these changes Aug 19, 2022

View reviewed changes

Merge branch 'feature/extensions' of github.com:dbwiddis/OpenSearch i…

156dc9d

…nto registerApi

dbwiddis mentioned this pull request Aug 19, 2022

[BUG] Gradle Check failures in SortedSetDVStringFieldDataTests.testSortMissingFirstReverse #4265

Closed

reta and others added 3 commits August 19, 2022 15:04

Fixing NodeGatewayStartedShards bwc (de)serialization issues (opensea…

de00029

…rch-project#4258) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Fix tests to account for TotalHits uncertainty

33ed951

Signed-off-by: Daniel Widdis <widdis@gmail.com>

Merge branch 'registerApi' of github.com:dbwiddis/OpenSearch into reg…

4e75c43

…isterApi

owaiskazi19 merged commit e3acafd into opensearch-project:feature/extensions Aug 19, 2022

dbwiddis deleted the registerApi branch August 19, 2022 22:33

This was referenced Aug 23, 2022

[Feature/extensions] Register REST API and forward REST requests to associated extension #4282

Merged

Register REST API and forward REST requests to associated extension opensearch-project/opensearch-sdk-java#101

Merged

ryanbogan mentioned this pull request Nov 17, 2022

[Feature/extensions] Merge to main tracking - Extension Points, initial REST implementation and registering Transport Actions #5271

Closed

Conversation

dbwiddis commented Aug 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Check List

Uh oh!

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 3, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 3, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 3, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 3, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 3, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 4, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 4, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 4, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Uh oh!

github-actions bot commented Aug 18, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

owaiskazi19 commented Aug 18, 2022

Uh oh!

github-actions bot commented Aug 18, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 18, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

owaiskazi19 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 18, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 19, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 19, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 19, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 19, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 19, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 19, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 19, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

dbwiddis commented Aug 2, 2022 •

edited

Loading