Fixing NodeGatewayStartedShards bwc (de)serialization issues#4258
Merged
reta merged 1 commit intoopensearch-project:mainfrom Aug 18, 2022
Merged
Fixing NodeGatewayStartedShards bwc (de)serialization issues#4258reta merged 1 commit intoopensearch-project:mainfrom
reta merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Contributor
Author
|
@dreamer-89 fyi |
dreamer-89
approved these changes
Aug 18, 2022
Member
dreamer-89
left a comment
There was a problem hiding this comment.
Thanks @reta for fixing this.
Contributor
Gradle Check (Jenkins) Run Completed with:
|
dbwiddis
pushed a commit
to dbwiddis/OpenSearch
that referenced
this pull request
Aug 19, 2022
…rch-project#4258) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dbwiddis
pushed a commit
to dbwiddis/OpenSearch
that referenced
this pull request
Aug 19, 2022
…rch-project#4258) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
owaiskazi19
pushed a commit
that referenced
this pull request
Aug 19, 2022
* Provide Extension API to OpenSearch Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add tests Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add javadocs Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add parsing of API requests Signed-off-by: Daniel Widdis <widdis@gmail.com> * Tweak API parsing for more flexible user formatting Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove forbidden toUpperCase usage Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix failing test as we now register four handlers Signed-off-by: Daniel Widdis <widdis@gmail.com> * Rename Api to RestApi Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix errors in previous merge conflict resolution Signed-off-by: Daniel Widdis <widdis@gmail.com> * Rename RestApi to RestActions Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix tests to fail on the correct wrong thing Signed-off-by: Daniel Widdis <widdis@gmail.com> * More verbose variable name Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix license header Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fixing NodeGatewayStartedShards bwc (de)serialization issues (#4258) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Fixing NodeGatewayStartedShards bwc (de)serialization issues (#4258) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Fix tests to account for TotalHits uncertainty Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko andriy.redko@aiven.io
Description
The bwc (de)serialization issue has been introduced by [1], breaking the
mainbuilds (fe [2])[1] #4252
[2] https://build.ci.opensearch.org/job/gradle-check/1896/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_indices_open_20_multiple_indices_Only_wildcard_/
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.