Fix flaky test RemoteClusterStateServiceTests.testReadClusterStateInParallel_ExceptionDuringRead#19437
Merged
cwperks merged 1 commit intoopensearch-project:mainfrom Sep 26, 2025
Conversation
…arallel_ExceptionDuringRead Signed-off-by: Craig Perkins <cwperx@amazon.com>
andrross
approved these changes
Sep 26, 2025
Member
andrross
left a comment
There was a problem hiding this comment.
Agreed this should be merged. Exception instances are mutable and generally should not be reused.
Contributor
|
❕ Gradle check result for 3402fa9: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19437 +/- ##
============================================
- Coverage 73.03% 72.97% -0.07%
+ Complexity 69997 69911 -86
============================================
Files 5676 5676
Lines 320923 320923
Branches 46392 46392
============================================
- Hits 234396 234180 -216
- Misses 67610 67766 +156
- Partials 18917 18977 +60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
66 tasks
karenyrx
pushed a commit
to karenyrx/OpenSearch
that referenced
this pull request
Sep 29, 2025
…arallel_ExceptionDuringRead (opensearch-project#19437) Signed-off-by: Craig Perkins <cwperx@amazon.com>
peteralfonsi
pushed a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
Oct 15, 2025
…arallel_ExceptionDuringRead (opensearch-project#19437) Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
added a commit
that referenced
this pull request
Dec 27, 2025
* Bump log4j from 2.21.0 to 2.25.3 (#20308) * Bump log4j from 2.21.0 to 2.25.3 Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add CHANGELOG entry Signed-off-by: Craig Perkins <cwperx@amazon.com> * Filter out known messages Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix arg count Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit e047211) * Update plugins/transport-grpc/build.gradle Co-authored-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Craig Perkins <craig5008@gmail.com> * Remove unused files Signed-off-by: Craig Perkins <cwperx@amazon.com> * Broaden perm Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix flaky test RemoteClusterStateServiceTests.testReadClusterStateInParallel_ExceptionDuringRead (#19437) Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Craig Perkins <craig5008@gmail.com> Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a simple change to throw a new instance of an IOException every time
container.readBlobis invoked instead of re-using the same instance.This PR is good from a hygiene perspective to not re-use the same object every time a new exception is thrown, but the underlying issue in apache/logging-log4j2#3940 and apache/logging-log4j2#3933 should still be fixed.
This PR is not meant as a replacement for #19430. I'm opening this up to share the reason for the test failure in this particular test case.
The anomaly-detection repo is also seeing this on
./gradlew test --tests MultiEntityResultTests.testQueryErrorEndRunNotNow -iRelated Issues
Resolves #19325
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.