Skip to content

[Backport 2.19] Bump log4j from 2.21.0 to 2.25.3 (#20308)#20314

Merged
cwperks merged 6 commits intoopensearch-project:2.19from
cwperks:backport-20308-to-2.19
Dec 27, 2025
Merged

[Backport 2.19] Bump log4j from 2.21.0 to 2.25.3 (#20308)#20314
cwperks merged 6 commits intoopensearch-project:2.19from
cwperks:backport-20308-to-2.19

Conversation

@cwperks
Copy link
Copy Markdown
Member

@cwperks cwperks commented Dec 23, 2025

Manual backport of #20308 to 2.19

* Bump log4j from 2.21.0 to 2.25.3

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add CHANGELOG entry

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Filter out known messages

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix arg count

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit e047211)
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 23, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

cwperks and others added 2 commits December 23, 2025 18:06
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Craig Perkins <craig5008@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 5b05faf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 1411591: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@cwperks
Copy link
Copy Markdown
Member Author

cwperks commented Dec 23, 2025

Error is JSM related:

    ERROR:The environment variable log4j.unbox.ringbuffer.size is not available to Log4j due to security restrictions.Source:
    EnvironmentPropertySource.java@63
    Throwable:
    java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "getenv.log4j.unbox.ringbuffer.size")
    	at java.****/java.security.AccessControlContext.checkPermission(AccessControlContext.java:488)
    	at java.****/java.security.AccessController.checkPermission(AccessController.java:1071)
    	at java.****/java.lang.SecurityManager.checkPermission(SecurityManager.java:411)
    	at java.****/java.lang.System.getenv(System.java:1154)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 7c9f6e3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 7c9f6e3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 7c9f6e3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…arallel_ExceptionDuringRead (opensearch-project#19437)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Copy link
Copy Markdown
Member Author

cwperks commented Dec 24, 2025

Updated the PR to also cherry-pick the changes from #19437

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 72df3a8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 72df3a8: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.04%. Comparing base (1f78365) to head (72df3a8).
⚠️ Report is 1 commits behind head on 2.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               2.19   #20314      +/-   ##
============================================
+ Coverage     71.99%   72.04%   +0.04%     
+ Complexity    65993    65979      -14     
============================================
  Files          5342     5342              
  Lines        307364   307364              
  Branches      44857    44857              
============================================
+ Hits         221298   221431     +133     
+ Misses        67624    67414     -210     
- Partials      18442    18519      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants