Skip to content

[Backport 3.0] Unset discovery nodes for every transport node actions request (#17682)#18047

Merged
andrross merged 1 commit intoopensearch-project:3.0from
gargmanik13:backport/backport-17682-to-3.0
Apr 23, 2025
Merged

[Backport 3.0] Unset discovery nodes for every transport node actions request (#17682)#18047
andrross merged 1 commit intoopensearch-project:3.0from
gargmanik13:backport/backport-17682-to-3.0

Conversation

@gargmanik13
Copy link
Copy Markdown
Contributor

Description

Unset discovery nodes for every transport node actions request (#17682)

Related Issues

Resolves #17008

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added >breaking Identifies a breaking change. Cluster Manager enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0 labels Apr 23, 2025
…earch-project#17682)

* Removed includeDiscoveryNodes from BaseNodesRequest

(cherry picked from commit 2bd3e3d)
Signed-off-by: Manik Garg <gargmanik1317@gmail.com>
@gargmanik13 gargmanik13 force-pushed the backport/backport-17682-to-3.0 branch from 0320b86 to b67101b Compare April 23, 2025 10:50
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for b67101b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gargmanik13
Copy link
Copy Markdown
Contributor Author

❌ Gradle check result for b67101b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Test Result (2 failures / ±0)
org.opensearch.repositories.s3.S3BlobContainerRetriesTests.classMethod
org.opensearch.repositories.s3.S3BlobContainerRetriesTests.classMethod

Flaky test - #17551

@andrross andrross changed the title Unset discovery nodes for every transport node actions request (#17682) [Backport 3.0] Unset discovery nodes for every transport node actions request (#17682) Apr 23, 2025
@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for b67101b: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (3.0@15b702d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ices/dangling/list/ListDanglingIndicesRequest.java 0.00% 2 Missing ⚠️
...luster/node/hotthreads/NodesHotThreadsRequest.java 0.00% 1 Missing ⚠️
.../node/reload/NodesReloadSecureSettingsRequest.java 50.00% 1 Missing ⚠️
...on/admin/cluster/node/usage/NodesUsageRequest.java 0.00% 1 Missing ⚠️
...napshots/status/TransportNodesSnapshotsStatus.java 0.00% 1 Missing ⚠️
...arch/action/admin/cluster/wlm/WlmStatsRequest.java 50.00% 1 Missing ⚠️
...ndices/dangling/find/FindDanglingIndexRequest.java 0.00% 1 Missing ⚠️
...ch/gateway/TransportNodesListGatewayMetaState.java 0.00% 1 Missing ⚠️
...y/TransportNodesListGatewayStartedShardsBatch.java 0.00% 1 Missing ⚠️
...es/store/TransportNodesListShardStoreMetadata.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@          Coverage Diff           @@
##             3.0   #18047   +/-   ##
======================================
  Coverage       ?   72.57%           
  Complexity     ?    67140           
======================================
  Files          ?     5478           
  Lines          ?   310022           
  Branches       ?    45065           
======================================
  Hits           ?   225012           
  Misses         ?    66680           
  Partials       ?    18330           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit b0a4eb5 into opensearch-project:3.0 Apr 23, 2025
57 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cluster Manager Project Board Apr 23, 2025
@gargmanik13 gargmanik13 deleted the backport/backport-17682-to-3.0 branch April 28, 2025 06:31
prudhvigodithi pushed a commit to prudhvigodithi/OpenSearch that referenced this pull request May 6, 2025
…earch-project#17682) (opensearch-project#18047)

* Removed includeDiscoveryNodes from BaseNodesRequest

(cherry picked from commit 2bd3e3d)
Signed-off-by: Manik Garg <gargmanik1317@gmail.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>breaking Identifies a breaking change. Cluster Manager enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants