Unset discovery nodes for every transport node actions request#17682
Merged
shwetathareja merged 6 commits intoopensearch-project:mainfrom Apr 22, 2025
Merged
Unset discovery nodes for every transport node actions request#17682shwetathareja merged 6 commits intoopensearch-project:mainfrom
shwetathareja merged 6 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Manik Garg <garmanik@amazon.com>
Contributor
|
❕ Gradle check result for abf03ec: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17682 +/- ##
============================================
+ Coverage 72.59% 72.60% +0.01%
+ Complexity 67172 67128 -44
============================================
Files 5478 5478
Lines 310125 310113 -12
Branches 45080 45079 -1
============================================
+ Hits 225135 225159 +24
+ Misses 66676 66582 -94
- Partials 18314 18372 +58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 25, 2025
Contributor
Author
Test Result (1 failure / +1) Flaky Test: #17271 |
Contributor
|
❌ Gradle check result for 776ebcc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Apr 22, 2025
Contributor
shwetathareja
approved these changes
Apr 22, 2025
2bd3e3d
into
opensearch-project:main
30 of 31 checks passed
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-3.0 3.0
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-3.0
# Create a new branch
git switch --create backport/backport-17682-to-3.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2bd3e3dcc9a97f8cfd2065b09a125079a2d35f3c
# Push it to GitHub
git push --set-upstream origin backport/backport-17682-to-3.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-3.0Then, create a pull request where the |
gargmanik13
added a commit
to gargmanik13/OpenSearch
that referenced
this pull request
Apr 23, 2025
…earch-project#17682) * Removed includeDiscoveryNodes from BaseNodesRequest Signed-off-by: Manik Garg <garmanik@amazon.com> (cherry picked from commit 2bd3e3d)
Merged
3 tasks
gargmanik13
added a commit
to gargmanik13/OpenSearch
that referenced
this pull request
Apr 23, 2025
…earch-project#17682) * Removed includeDiscoveryNodes from BaseNodesRequest (cherry picked from commit 2bd3e3d) Signed-off-by: Manik Garg <gargmanik1317@gmail.com>
andrross
pushed a commit
that referenced
this pull request
Apr 23, 2025
x-INFiN1TY-x
pushed a commit
to x-INFiN1TY-x/OpenSearch_Local
that referenced
this pull request
Apr 24, 2025
…earch-project#17682) * Removed includeDiscoveryNodes from BaseNodesRequest Signed-off-by: Manik Garg <garmanik@amazon.com> Signed-off-by: Tanishq Ranjan <tqranjan@amazon.com>
gargmanik13
added a commit
to gargmanik13/OpenSearch
that referenced
this pull request
Apr 29, 2025
Signed-off-by: Manik Garg <gargmanik1317@gmail.com>
3 tasks
andrross
pushed a commit
that referenced
this pull request
Apr 29, 2025
andrross
pushed a commit
that referenced
this pull request
Apr 29, 2025
(cherry picked from commit d706593) Signed-off-by: Manik Garg <gargmanik1317@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
prudhvigodithi
pushed a commit
to prudhvigodithi/OpenSearch
that referenced
this pull request
May 6, 2025
…earch-project#17682) (opensearch-project#18047) * Removed includeDiscoveryNodes from BaseNodesRequest (cherry picked from commit 2bd3e3d) Signed-off-by: Manik Garg <gargmanik1317@gmail.com> Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
prudhvigodithi
pushed a commit
to prudhvigodithi/OpenSearch
that referenced
this pull request
May 6, 2025
…rch-project#18140) (opensearch-project#18141) (cherry picked from commit d706593) Signed-off-by: Manik Garg <gargmanik1317@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
…earch-project#17682) * Removed includeDiscoveryNodes from BaseNodesRequest Signed-off-by: Manik Garg <garmanik@amazon.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
…earch-project#17682) * Removed includeDiscoveryNodes from BaseNodesRequest Signed-off-by: Manik Garg <garmanik@amazon.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continuation to #15131, unsetting discovery nodes for every request before sending transport request to individual nodes.
Removed includeDiscoveryNodes field from BaseNodesRequest.
Related Issues
Resolves #17008
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.