Skip to content

Add default implementation to new finalizeSnapshot() in Repository#16128

Merged
sachinpkale merged 1 commit intoopensearch-project:mainfrom
sachinpkale:repository-fixes
Sep 30, 2024
Merged

Add default implementation to new finalizeSnapshot() in Repository#16128
sachinpkale merged 1 commit intoopensearch-project:mainfrom
sachinpkale:repository-fixes

Conversation

@sachinpkale
Copy link
Copy Markdown
Member

Description

  • With snapshot V2 changes, create flow introduced a new overloaded method of Repository.finalizeSnapshot
  • But this new method does not have default implementation. Due to this, external repository implementations can fail with compiler error.
  • In this PR, we provided a default implementation for the new method.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 606b547: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 606b547: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 606b547: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.92%. Comparing base (0dba562) to head (606b547).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/org/opensearch/repositories/Repository.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16128      +/-   ##
============================================
- Coverage     72.00%   71.92%   -0.09%     
+ Complexity    64487    64460      -27     
============================================
  Files          5288     5288              
  Lines        301419   301424       +5     
  Branches      43549    43550       +1     
============================================
- Hits         217026   216787     -239     
- Misses        66587    66815     +228     
- Partials      17806    17822      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit 9a5c7b2 into opensearch-project:main Sep 30, 2024
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Sep 30, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 30, 2024
…16128)

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
(cherry picked from commit 9a5c7b2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
hainenber pushed a commit to hainenber/OpenSearch that referenced this pull request Oct 1, 2024
reta pushed a commit that referenced this pull request Oct 3, 2024
…16128)

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
(cherry picked from commit 9a5c7b2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta added a commit that referenced this pull request Oct 3, 2024
…n Repository (#16141)

* Add default implementation to new finalizeSnapshot() in Repository (#16128)

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
(cherry picked from commit 9a5c7b2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix japicmp configuration by treating abstract-to-default method changes as non-breaking

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
ruai0511 pushed a commit to ruai0511/OpenSearch that referenced this pull request Oct 4, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants