Skip to content

[Backport 2.x] Add default implementation to new finalizeSnapshot() in Repository#16141

Merged
reta merged 2 commits into2.xfrom
backport/backport-16128-to-2.x
Oct 3, 2024
Merged

[Backport 2.x] Add default implementation to new finalizeSnapshot() in Repository#16141
reta merged 2 commits into2.xfrom
backport/backport-16128-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot Bot commented Sep 30, 2024

Backport 9a5c7b2 from #16128.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 30, 2024

✅ Gradle check result for 55d9a19: SUCCESS

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.73%. Comparing base (06ee966) to head (87c1761).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...n/java/org/opensearch/repositories/Repository.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16141      +/-   ##
============================================
+ Coverage     71.71%   71.73%   +0.01%     
- Complexity    64825    64838      +13     
============================================
  Files          5279     5279              
  Lines        302913   302914       +1     
  Branches      44066    44066              
============================================
+ Hits         217242   217290      +48     
+ Misses        67537    67507      -30     
+ Partials      18134    18117      -17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2024

❌ Gradle check result for cab3167: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions Bot and others added 2 commits October 3, 2024 09:30
@github-actions @reta
Add default implementation to new finalizeSnapshot() in Repository (#…
847ba51 
…16128)

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
(cherry picked from commit 9a5c7b2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@reta
Fix japicmp configuration by treating abstract-to-default method chan…
87c1761 
…ges as non-breaking

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta force-pushed the backport/backport-16128-to-2.x branch from cab3167 to 87c1761 Compare October 3, 2024 13:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2024

❌ Gradle check result for 87c1761: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2024

❌ Gradle check result for 87c1761: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2024

✅ Gradle check result for 87c1761: SUCCESS

@reta reta merged commit e2e6757 into 2.x Oct 3, 2024
@github-actions github-actions Bot deleted the backport/backport-16128-to-2.x branch October 3, 2024 16:09
@reta reta mentioned this pull request Oct 3, 2024
Merged
This was referenced Oct 3, 2024
Open
Open
Open
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reta reta reta approved these changes

@sachinpkale sachinpkale sachinpkale approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reta @sachinpkale