Skip to content

Apply Kotlin style class reference in AddMockitoExtensionIfAnnotationsUsed#890

Merged
timtebeek merged 6 commits intomainfrom
fix-mockito-extension-kotlin
Jan 13, 2026
Merged

Apply Kotlin style class reference in AddMockitoExtensionIfAnnotationsUsed#890
timtebeek merged 6 commits intomainfrom
fix-mockito-extension-kotlin

Conversation

@Laurens-W
Copy link
Contributor

@Laurens-W Laurens-W commented Jan 13, 2026

What's changed?

Expanded AddMockitoExtensionIfAnnotationsUsed to take Kotlin files into consideration

What's your motivation?

Currently the recipe adds a Java style class reference which doesn't compile in Kotlin

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@Laurens-W Laurens-W self-assigned this Jan 13, 2026
@Laurens-W Laurens-W added the bug Something isn't working label Jan 13, 2026
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Jan 13, 2026
@Laurens-W Laurens-W marked this pull request as ready for review January 13, 2026 15:56
@Laurens-W
Copy link
Contributor Author

Locally seeing the tests succeed after force reloading dependencies, may have to delete caches to get CI going here
image

Copy link
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks! I'd briefly explored whether this could be a single visitor just swapping out the template, but that then fails because JavaTemplate.Builder takes a .javaParser whereas KotlinTemplate.Builder takes a .parser. At that point it become no clearer to use a single visitor I think.

@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in OpenRewrite Jan 13, 2026
@timtebeek timtebeek added recipe Recipe request mockito labels Jan 13, 2026
@timtebeek timtebeek merged commit 2c43283 into main Jan 13, 2026
2 checks passed
@timtebeek timtebeek deleted the fix-mockito-extension-kotlin branch January 13, 2026 16:27
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Jan 13, 2026
mergify bot added a commit to robfrank/linklift that referenced this pull request Jan 25, 2026
…rom 3.25.0 to 3.26.0 [skip ci]

[//]: # (dependabot-start)
⚠️ \*\*Dependabot is rebasing this PR\*\* ⚠️
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
---
[//]: # (dependabot-end)
Bumps [org.openrewrite.recipe:rewrite-testing-frameworks](https://github.com/openrewrite/rewrite-testing-frameworks) from 3.25.0 to 3.26.0.
Release notes

*Sourced from [org.openrewrite.recipe:rewrite-testing-frameworks's releases](https://github.com/openrewrite/rewrite-testing-frameworks/releases).*

> 3.26.0
> ------
>
> What's Changed
> --------------
>
> * Transform `Assume` methods to without a direct counterpart to equivalent `Assumptions` by [`@​cortlepp`](https://github.com/cortlepp) in [openrewrite/rewrite-testing-frameworks#889](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/889)
> * Apply Kotlin style class reference in `AddMockitoExtensionIfAnnotationsUsed` by [`@​Laurens-W`](https://github.com/Laurens-W) in [openrewrite/rewrite-testing-frameworks#890](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/890)
>
> New Contributors
> ----------------
>
> * [`@​cortlepp`](https://github.com/cortlepp) made their first contribution in [openrewrite/rewrite-testing-frameworks#889](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/889)
>
> **Full Changelog**: <openrewrite/rewrite-testing-frameworks@v3.25.0...v3.26.0>


Commits

* [`17ef798`](openrewrite/rewrite-testing-frameworks@17ef798) Replace `getEstimatedEffortPerOccurrence()` method with field
* [`49b6e85`](openrewrite/rewrite-testing-frameworks@49b6e85) Replace `getTags()` method with field
* [`cec049e`](openrewrite/rewrite-testing-frameworks@cec049e) Update Gradle wrapper to 9.3.0
* [`ae15942`](openrewrite/rewrite-testing-frameworks@ae15942) Use `hasModifier` instead of `getModifiers().stream().anyMatch()`
* [`3c16fbc`](openrewrite/rewrite-testing-frameworks@3c16fbc) Replace `getDisplayName()` and `getDescription()` methods with fields
* [`7150900`](openrewrite/rewrite-testing-frameworks@7150900) OpenRewrite recipe best practices
* [`2c43283`](openrewrite/rewrite-testing-frameworks@2c43283) Apply Kotlin style class reference in `AddMockitoExtensionIfAnnotationsUsed` ...
* [`e9dab31`](openrewrite/rewrite-testing-frameworks@e9dab31) Transform `Assume` methods to without a direct counterpart to equivalent `Ass...
* [`aefa2b0`](openrewrite/rewrite-testing-frameworks@aefa2b0) Replace `getDisplayName()` and `getDescription()` methods with fields
* [`945be5c`](openrewrite/rewrite-testing-frameworks@945be5c) `AssertTrueInstanceofToAssertInstanceOf` should handle custom types
* See full diff in [compare view](openrewrite/rewrite-testing-frameworks@v3.25.0...v3.26.0)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=org.openrewrite.recipe:rewrite-testing-frameworks&package-manager=maven&previous-version=3.25.0&new-version=3.26.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working mockito recipe Recipe request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants