Fix KotlinTemplate building for annotations#6522
Merged
Conversation
…eGenerator so that KotlinAnnotationTemplateGenerator can build up a valid template
timtebeek
reviewed
Jan 13, 2026
...e-java/src/main/java/org/openrewrite/java/internal/template/AnnotationTemplateGenerator.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Jan 13, 2026
Member
timtebeek
left a comment
There was a problem hiding this comment.
Seems reasonable to me, thanks! Added a very small comment; the class itself is already in an internal package, but still we've seen that's not always stopping folks.
3 tasks
timtebeek
approved these changes
Jan 13, 2026
...e-java/src/main/java/org/openrewrite/java/internal/template/AnnotationTemplateGenerator.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/openrewrite/kotlin/internal/template/KotlinAnnotationTemplateGenerator.java
Show resolved
Hide resolved
...rc/main/java/org/openrewrite/kotlin/internal/template/KotlinAnnotationTemplateGenerator.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Jan 13, 2026
...e-java/src/main/java/org/openrewrite/java/internal/template/AnnotationTemplateGenerator.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Jan 13, 2026
...rc/main/java/org/openrewrite/kotlin/internal/template/KotlinAnnotationTemplateGenerator.java
Outdated
Show resolved
Hide resolved
knutwannheden
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Introduces extensibility to the AnnotationTemplateGenerator so that other languages (like Kotlin) can intercept certain steps
Introduced Kotlin specific AnnotationTemplateGenerator so that KotlinTemplate can create valid snippets for annotations
What's your motivation?
AddMockitoExtensionIfAnnotationsUsedcurrently adds the annotation with a Java style class reference, I'm working on expanding that to work for KotlinAny additional context
Without this change a KotlinTemplate like this
KotlinTemplate.builder("@ExtendWith(MockitoExtension::class)")will complain about the$before Class and PlaceholderChecklist