Add missing RSPEC tags and fix inconsistent tag formatting#826
Merged
Add missing RSPEC tags and fix inconsistent tag formatting#826
Conversation
Add RSPEC tags to 13 recipes by cross-referencing with SonarQube rules: - LambdaBlockToExpression (S1602) - ChainStringBuilderAppendCalls (S3024) - UnwrapRepeatableAnnotations (S1710) - ReplaceTextBlockWithString (S5663) - RemoveUnneededBlock (S1199) - RemoveSystemOutPrintln (S106) - InstanceOfPatternMatch (S6201) - UseStandardCharset (S4719) - ExplicitCharsetOnStringGetBytes (S4719) - ReplaceStackWithDeque (S1149) - SimplifyTernary (S1125) - SimplifyConstantIfBranchExecution (S6646) - UnnecessaryReturnAsLastStatement (S3626) Fix NoFinalizer tag from S1111 to S1113 (S1113 = "finalize() should not be overridden" is the correct match; S1111 stays on RemoveCallsToObjectFinalize for "finalize() should not be called"). Fix missing "S" prefix in RSPEC tags for SimplifyBooleanExpression, SimplifyBooleanExpressionWithDeMorgan, and ReplaceDuplicateStringLiterals.
steve-aom-elliott
approved these changes
Mar 10, 2026
mergify bot
added a commit
to robfrank/linklift
that referenced
this pull request
Mar 19, 2026
… 2.29.0 to 2.30.0 [skip ci] Bumps [org.openrewrite.recipe:rewrite-static-analysis](https://github.com/openrewrite/rewrite-static-analysis) from 2.29.0 to 2.30.0. Release notes *Sourced from [org.openrewrite.recipe:rewrite-static-analysis's releases](https://github.com/openrewrite/rewrite-static-analysis/releases).* > 2.30.0 > ------ > > What's Changed > -------------- > > * Disabling C# tests if no .dotnet available by [`@greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#825](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/825) > * Add missing RSPEC tags and fix inconsistent tag formatting by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#826](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/826) > * Remove `RemoveTrailingWhitespace` by [`@greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#827](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/827) > > **Full Changelog**: <openrewrite/rewrite-static-analysis@v2.29.0...v2.30.0> Commits * [`c7cc3e5`](openrewrite/rewrite-static-analysis@c7cc3e5) Remove RemoveTrailingWhitespace ([#827](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/827)) * [`1f60c9e`](openrewrite/rewrite-static-analysis@1f60c9e) Lombok Best Practices * [`f3d49bc`](openrewrite/rewrite-static-analysis@f3d49bc) OpenRewrite recipe best practices * [`d672b21`](openrewrite/rewrite-static-analysis@d672b21) Add missing RSPEC tags and fix inconsistent tag formatting ([#826](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/826)) * [`bf904bf`](openrewrite/rewrite-static-analysis@bf904bf) Remove `CustomImportOrder` from `CodeCleanup` * [`0fbe973`](openrewrite/rewrite-static-analysis@0fbe973) Disabling C# tests if no .dotnet available ([#825](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/825)) * See full diff in [compare view](openrewrite/rewrite-static-analysis@v2.29.0...v2.30.0) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NoFinalizertag from S1111 to S1113 (S1113 = "finalize() should not be overridden"; S1111 stays onRemoveCallsToObjectFinalize)SimplifyBooleanExpression,SimplifyBooleanExpressionWithDeMorgan, andReplaceDuplicateStringLiteralsNew tags added
Test plan
./gradlew compileJavapasses successfully