Skip to content

Disabling C# tests if no .dotnet available#825

Merged
greg-at-moderne merged 1 commit intomainfrom
greg-check-csharp-test
Mar 6, 2026
Merged

Disabling C# tests if no .dotnet available#825
greg-at-moderne merged 1 commit intomainfrom
greg-check-csharp-test

Conversation

@greg-at-moderne
Copy link
Copy Markdown
Contributor

What's changed?

Conditionally disabling the C# tests we have if the .NET runtime is not available.

What's your motivation?

Fix broken CI:

java.lang.IllegalStateException: Could not find C# Rewrite project. Please set csharpServerEntry() on the builder. Expected to find OpenRewrite.dll in ~/.dotnet/tools/.store/openrewrite.csharp/ or OpenRewrite/OpenRewrite.csproj in the project directory.
            at org.openrewrite.csharp.rpc.CSharpRewriteRpc$Builder.findCSharpServerEntry(CSharpRewriteRpc.java:370)

@greg-at-moderne greg-at-moderne self-assigned this Mar 6, 2026
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Mar 6, 2026
@greg-at-moderne greg-at-moderne marked this pull request as ready for review March 6, 2026 09:58
@greg-at-moderne greg-at-moderne merged commit 0fbe973 into main Mar 6, 2026
1 check passed
@greg-at-moderne greg-at-moderne deleted the greg-check-csharp-test branch March 6, 2026 09:58
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenRewrite Mar 6, 2026
mergify bot added a commit to robfrank/linklift that referenced this pull request Mar 19, 2026
… 2.29.0 to 2.30.0 [skip ci]

Bumps [org.openrewrite.recipe:rewrite-static-analysis](https://github.com/openrewrite/rewrite-static-analysis) from 2.29.0 to 2.30.0.
Release notes

*Sourced from [org.openrewrite.recipe:rewrite-static-analysis's releases](https://github.com/openrewrite/rewrite-static-analysis/releases).*

> 2.30.0
> ------
>
> What's Changed
> --------------
>
> * Disabling C# tests if no .dotnet available by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#825](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/825)
> * Add missing RSPEC tags and fix inconsistent tag formatting by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#826](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/826)
> * Remove `RemoveTrailingWhitespace` by [`@​greg-at-moderne`](https://github.com/greg-at-moderne) in [openrewrite/rewrite-static-analysis#827](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/827)
>
> **Full Changelog**: <openrewrite/rewrite-static-analysis@v2.29.0...v2.30.0>


Commits

* [`c7cc3e5`](openrewrite/rewrite-static-analysis@c7cc3e5) Remove RemoveTrailingWhitespace ([#827](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/827))
* [`1f60c9e`](openrewrite/rewrite-static-analysis@1f60c9e) Lombok Best Practices
* [`f3d49bc`](openrewrite/rewrite-static-analysis@f3d49bc) OpenRewrite recipe best practices
* [`d672b21`](openrewrite/rewrite-static-analysis@d672b21) Add missing RSPEC tags and fix inconsistent tag formatting ([#826](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/826))
* [`bf904bf`](openrewrite/rewrite-static-analysis@bf904bf) Remove `CustomImportOrder` from `CodeCleanup`
* [`0fbe973`](openrewrite/rewrite-static-analysis@0fbe973) Disabling C# tests if no .dotnet available ([#825](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/825))
* See full diff in [compare view](openrewrite/rewrite-static-analysis@v2.29.0...v2.30.0)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=org.openrewrite.recipe:rewrite-static-analysis&package-manager=maven&previous-version=2.29.0&new-version=2.30.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant