8252715: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java on Linux#23
8252715: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java on Linux#23prrace wants to merge 1 commit intoopenjdk:masterfrom prrace:8252715
Conversation
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
|
@prrace To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an RFR email automatically sent to the correct mailing list, you will need to add one or more labels manually using the |
|
/label add awt |
|
@prrace |
| java/awt/event/KeyEvent/ExtendedModifiersTest/ExtendedModifiersTest.java 8129778 generic-all | ||
| java/awt/event/KeyEvent/KeyMaskTest/KeyMaskTest.java 8129778 generic-all | ||
| java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java 8252713 linux-all | ||
| java/awt/event/MouseEvent/MouseButtonsAndKeyMasksTest/MouseButtonsAndKeyMasksTest.java 8129778 generic-all |
|
@prrace This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
There are currently no new commits on the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
Co-authored-by: Xin Liu <xxinliu@amazon.com>
* Even more review comments
* Re-write of atomic copy loops
* Change name of UnsafeCopyMemory{,Mark} to UnsafeMemory{Access,Mark}
* Only add a memory mark for byte unaligned fill
* Remove MUSL_LIBC ifdef
* Remove MUSL_LIBC ifdef
…penjdk#23) * Instance patterns represented by instance methods in the translation * Second Approach: rely on the mangled name
- Add assert for _analytics in constructor instead of runtime null check - Remove unnecessary null check for _analytics before use - Remove unnecessary region_size > 0 check (region size can never be 0) - Remove unused total_regions variable - Move Ticks::now() outside loop for better performance Addresses issues openjdk#17, openjdk#20, openjdk#22, openjdk#23 from Thomas review
- Add assert for _analytics in constructor instead of runtime null check - Remove unnecessary null check for _analytics before use - Remove unnecessary region_size > 0 check (region size can never be 0) - Remove unused total_regions variable - Move Ticks::now() outside loop for better performance Addresses issues openjdk#17, openjdk#20, openjdk#22, openjdk#23 from Thomas review
Bug :https://bugs.openjdk.java.net/browse/JDK-8252715
We've opened a bug to track some xserver issues running this test that cause all subsequent tests to fail
because they can't connect even though the server is still running.
Possibly it is a system configuration issue or perhaps an Xserver bug,
but it has been seen on more than one Ubuntu system running 19.10 and 20.04 and
I think we should problem list it to see if that cures/hides it .. or moves it .. as this happens
so frequently we can't wait for an investigation to complete.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/23/head:pull/23$ git checkout pull/23