8252817: Cleanup the classes in the java.awt.color package by mrserb · Pull Request #22 · openjdk/jdk

mrserb · 2020-09-05T21:32:42Z

Class declarations reformat
Docs cleanup

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8252817: Cleanup the classes in the java.awt.color package

Reviewers

Jayathirth D V (@jayathirthrao - Reviewer)
Pankaj Bansal (@pankaj-bansal - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/22/head:pull/22
$ git checkout pull/22

- Class declarations cleanup - docs cleanup

mrserb · 2020-09-05T21:34:11Z

     */
-    public static final int icSigXYZData        = 0x58595A20;    /* 'XYZ ' */
+    public static final int icSigXYZData = 0x58595A20;



Inline comment:
Looks like this type of documentation was used before we added javadoc for each constant.

bridgekeeper · 2020-09-05T21:34:31Z

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-09-05T21:35:32Z

@mrserb The following labels will be automatically applied to this pull request: 2d. When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

mlbridge · 2020-09-05T21:38:03Z

Webrevs

00: Full (5dfb8c6)

mrserb · 2020-09-05T22:05:45Z

/test tier1

openjdk · 2020-09-05T22:29:45Z

Could not create test job

jayathirthrao

Looks good to me.

openjdk · 2020-09-09T05:48:47Z

@mrserb This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252817: Cleanup the classes in the java.awt.color package

Reviewed-by: jdv, pbansal

If you would like to add a summary, use the /summary command.
To credit additional contributors, use the /contributor command.
To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 44 commits pushed to the master branch:

44a74da: 8252919: JDK built with --enable-cds=no fails with NoClassDefFoundError
418e4a2: 8252830: Correct missing javadoc comments in java.rmi module
41d29b7: 8252774: remove jdk.test.lib.FileInstaller action from graalunit tests
5b30a83: 8252778: remove jdk.test.lib.FileInstaller action from compiler/c2/stemmer test
8db3335: 8247928: Refactor G1ConcurrentMarkThread for mark abort
7ccf435: 8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su…
d236cf4: 8252995: Non-PCH builds broken by JDK-8250961
6a00534: 8250961: Move Universe::update_heap_info_at_gc to CollectedHeap
f78f780: 8252889: Obsolete -XX:+InsertMemBarAfterArraycopy
f933961: 8252980: comment only changes extracted from JDK-8247281
... and 34 more: https://git.openjdk.java.net/jdk/compare/4b3a0b789ebf389a9589c9af2d3922fb91916d92...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 44a74dac957ca7cc10eaddafb6bd32b74a8d84c8.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

pankaj-bansal

+1

mrserb · 2020-09-10T19:25:37Z

/integrate

openjdk · 2020-09-10T19:26:49Z

@mrserb Since your change was applied there have been 44 commits pushed to the master branch:

44a74da: 8252919: JDK built with --enable-cds=no fails with NoClassDefFoundError
418e4a2: 8252830: Correct missing javadoc comments in java.rmi module
41d29b7: 8252774: remove jdk.test.lib.FileInstaller action from graalunit tests
5b30a83: 8252778: remove jdk.test.lib.FileInstaller action from compiler/c2/stemmer test
8db3335: 8247928: Refactor G1ConcurrentMarkThread for mark abort
7ccf435: 8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su…
d236cf4: 8252995: Non-PCH builds broken by JDK-8250961
6a00534: 8250961: Move Universe::update_heap_info_at_gc to CollectedHeap
f78f780: 8252889: Obsolete -XX:+InsertMemBarAfterArraycopy
f933961: 8252980: comment only changes extracted from JDK-8247281
... and 34 more: https://git.openjdk.java.net/jdk/compare/4b3a0b789ebf389a9589c9af2d3922fb91916d92...master

Your commit was automatically rebased without conflicts.

Pushed as commit ff21696.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

RISC-V: loom: Fix another frame::sender_sp_offset issue in stackChunkOopDesc::is_usable_in_chunk

@martinuy

Reviewed-by: @martinuy

…R, after PR openjdk#22.

) * Change to ctwrunner.sh to run java base module with inliner. Unlike ctw.sh, ctwrunner.sh tolerates fatal errors. It will restart the java process with the shifted starting point. * Change the script name from CTW_SCRIPT to CTW_DIST. --------- Co-authored-by: Xin Liu <xxinliu@amazon.com>

@martinuy

Reviewed-by: @martinuy

* Even more review comments * Re-write of atomic copy loops * Change name of UnsafeCopyMemory{,Mark} to UnsafeMemory{Access,Mark} * Only add a memory mark for byte unaligned fill

Only link restricted method doc-file if it is available

openjdk#21 Cleanup POM

Bring some cleanup from mainline to the BSD port

- Add assert for _analytics in constructor instead of runtime null check - Remove unnecessary null check for _analytics before use - Remove unnecessary region_size > 0 check (region size can never be 0) - Remove unused total_regions variable - Move Ticks::now() outside loop for better performance Addresses issues openjdk#17, openjdk#20, openjdk#22, openjdk#23 from Thomas review

8252817: Cleanup the classes in the java.awt.color package

5dfb8c6

- Class declarations cleanup - docs cleanup

mrserb commented Sep 5, 2020

View reviewed changes

mrserb marked this pull request as ready for review September 5, 2020 21:34

openjdk Bot added the rfr Pull request is ready for review label Sep 5, 2020

openjdk Bot added the 2d client-libs-dev@openjdk.org label Sep 5, 2020

jayathirthrao approved these changes Sep 9, 2020

View reviewed changes

openjdk Bot added the ready Pull request is ready to be integrated label Sep 9, 2020

pankaj-bansal approved these changes Sep 9, 2020

View reviewed changes

openjdk Bot closed this Sep 10, 2020

openjdk Bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 10, 2020

mrserb deleted the JDK-8252817 branch September 10, 2020 19:31

zhengxiaolinX pushed a commit to zhengxiaolinX/jdk that referenced this pull request Sep 13, 2022

Merge pull request openjdk#22 from zhengxiaolinX/JDK-8286301-20

11ad17e

RISC-V: loom: Fix another frame::sender_sp_offset issue in stackChunkOopDesc::is_usable_in_chunk

martinuy pushed a commit to martinuy/jdk that referenced this pull request Nov 18, 2022

Add nss.fips.cfg support to OpenJDK tree (openjdk#22)

f0a0bcc

Reviewed-by: @martinuy

martinuy added a commit to martinuy/jdk that referenced this pull request Nov 18, 2022

Changes to nss.fips.cfg can now be applied to a rh-openjdk/fips-17u P…

f096804

…R, after PR openjdk#22.

gnu-andrew added a commit to gnu-andrew/jdk that referenced this pull request Aug 18, 2023

Add nss.fips.cfg support to OpenJDK tree (openjdk#22)

1d4843f

Reviewed-by: @martinuy

openjdk-notifier Bot pushed a commit that referenced this pull request Apr 15, 2024

Set memory test (#22)

80b5a0c

* Even more review comments * Re-write of atomic copy loops * Change name of UnsafeCopyMemory{,Mark} to UnsafeMemory{Access,Mark} * Only add a memory mark for byte unaligned fill

openjdk-notifier Bot pushed a commit that referenced this pull request Oct 7, 2024

Merge pull request #22 from hns/restricted_better_javadoc

af0a13c

Only link restricted method doc-file if it is available

biboudis added a commit to biboudis/jdk that referenced this pull request May 8, 2025

Handle MatchCandidate properly (openjdk#22)

bdb9836

pf0n pushed a commit to pf0n/jdk that referenced this pull request Jul 9, 2025

Merge pull request openjdk#22 from AzeemJiva/master

1b7dc50

openjdk#21 Cleanup POM

snake66 added a commit to snake66/jdk that referenced this pull request Nov 13, 2025

Merge pull request openjdk#22 from snake66/freebsd-minor-cleanup

69bf091

Bring some cleanup from mainline to the BSD port

mhaessig mentioned this pull request Mar 5, 2026

8377541: C2: Memory Barrier IR nodes not eliminated for stable array element access #30077

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8252817: Cleanup the classes in the java.awt.color package#22

8252817: Cleanup the classes in the java.awt.color package#22
mrserb wants to merge 1 commit intoopenjdk:masterfrom
mrserb:JDK-8252817

mrserb commented Sep 5, 2020 •

edited by openjdk Bot

Loading

Uh oh!

mrserb Sep 5, 2020

Uh oh!

bridgekeeper Bot commented Sep 5, 2020

Uh oh!

openjdk Bot commented Sep 5, 2020

Uh oh!

mlbridge Bot commented Sep 5, 2020

Uh oh!

mrserb commented Sep 5, 2020

Uh oh!

openjdk Bot commented Sep 5, 2020

Uh oh!

jayathirthrao left a comment

Uh oh!

openjdk Bot commented Sep 9, 2020 •

edited

Loading

Uh oh!

pankaj-bansal left a comment

Uh oh!

mrserb commented Sep 10, 2020

Uh oh!

openjdk Bot commented Sep 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

mrserb commented Sep 5, 2020 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Download

Uh oh!

mrserb Sep 5, 2020

Choose a reason for hiding this comment

Uh oh!

bridgekeeper Bot commented Sep 5, 2020

Uh oh!

openjdk Bot commented Sep 5, 2020

Uh oh!

mlbridge Bot commented Sep 5, 2020

Webrevs

Uh oh!

mrserb commented Sep 5, 2020

Uh oh!

openjdk Bot commented Sep 5, 2020

Uh oh!

jayathirthrao left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk Bot commented Sep 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pankaj-bansal left a comment

Choose a reason for hiding this comment

Uh oh!

mrserb commented Sep 10, 2020

Uh oh!

openjdk Bot commented Sep 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

mrserb commented Sep 5, 2020 •

edited by openjdk Bot

Loading

openjdk Bot commented Sep 9, 2020 •

edited

Loading