Weights for YoloX Yolo v6 and Yolo v8#1126
Closed
Abdurrahheem wants to merge 2 commits intoopencv:4.xfrom
Closed
Conversation
fengyuentau
reviewed
Nov 23, 2023
Member
|
So are you going to add a test case that uses this model? Currently it is added but not used. |
Contributor
Author
You are right. Test is not yet added. Waiting for this PR to finish to add a PR with test |
Member
|
Ok, lets hold until you submit a new PR. |
This was referenced Nov 24, 2023
This was referenced Dec 1, 2023
Contributor
|
Maybe it would be easier to add two new models (6 and 8) to #1129 to avoid merge conflicts? |
Contributor
Author
|
@asmorkalov @mshabunin I propose to close this PR as the same addictions are in #1129 are present. No need for duplication? |
asmorkalov
pushed a commit
to opencv/opencv
that referenced
this pull request
Dec 11, 2023
Add test for YoloX Yolo v6 and Yolo v8 #24611 This PR adds test for YOLOv6 model (which was absent before) The onnx weights for the test are located in this PR [ #1126](opencv/opencv_extra#1126) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
Contributor
|
Replaced by #1129 |
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
Add test for YoloX Yolo v6 and Yolo v8 opencv#24611 This PR adds test for YOLOv6 model (which was absent before) The onnx weights for the test are located in this PR [ opencv#1126](opencv/opencv_extra#1126) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends download functionality for weights of yolox model from google drive
Problem
Yolox model weights are required for test in opencv repository (PR with the test is yet to be opened)