Skip to content

Add test for YoloX Yolo v6 and Yolo v8#24611

Merged
asmorkalov merged 17 commits intoopencv:4.xfrom
Abdurrahheem:ash/add_yolov6_test
Dec 11, 2023
Merged

Add test for YoloX Yolo v6 and Yolo v8#24611
asmorkalov merged 17 commits intoopencv:4.xfrom
Abdurrahheem:ash/add_yolov6_test

Conversation

@Abdurrahheem
Copy link
Copy Markdown
Contributor

@Abdurrahheem Abdurrahheem commented Nov 28, 2023

This PR adds test for YOLOv6 model (which was absent before)
The onnx weights for the test are located in this PR #1126

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
build_image:Custom=ubuntu:22.04
buildworker:Custom=linux-4

Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test differs from YoloX with pre-processing parameters and ground truth. Please extract post-processing code as function and re-use.

@Abdurrahheem Abdurrahheem marked this pull request as ready for review December 2, 2023 06:33
@asmorkalov asmorkalov changed the title Add test for YOLOv6 Add test for YoloX Yolo v6 and Yolo v8 Dec 4, 2023
This was referenced Dec 4, 2023
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov added this to the 4.9.0 milestone Dec 6, 2023
@opencv-alalek
Copy link
Copy Markdown
Contributor

Not sure why GHA doesn't see a problem with tests.

Locally:

  • there is no problem with the source branch
  • there is reproduced test failure with merged up-to-date 4.x branch (this case should be tested on CI)

Please squash and rebase your branch on up-to-date 4.x. And debug the problem.

@Abdurrahheem
Copy link
Copy Markdown
Contributor Author

Abdurrahheem commented Dec 8, 2023

@fengyuentau PR #24655 related to onnx_graph_simplifier is breaking yolox model parsing with this error:

ror: (-2:Unspecified error) in function 'handleNode'
> Node [Add@ai.onnx]:(onnx_node!/head/Add) parse error: OpenCV(4.8.0-dev) opencv/modules/dnn/src/layers/nary_eltwise_layers.cpp:142: error: (-215:Assertion failed) shape[i] == 1 || outShape[i] == 1 in function 'findCommonShape'

In the ADD node input shapes do not match.
Can you please take a look at please. Maybe @dkurt can also comment
Opened an issue #24671 related this

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Dec 8, 2023

@Abdurrahheem, sorry, I will take a look too.

@asmorkalov asmorkalov merged commit d3dd2e4 into opencv:4.x Dec 11, 2023
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
Add test for YoloX Yolo v6 and Yolo v8 opencv#24611

This PR adds test for YOLOv6 model (which was absent before)
The onnx weights for the test are located in this PR [ opencv#1126](opencv/opencv_extra#1126)

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants