-
-
Notifications
You must be signed in to change notification settings - Fork 56.5k
Bug3714 fix #3441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug3714 fix #3441
Conversation
|
I have already recreated the branch and merge to the master branch, based on Alex's suggestion. Yet, why the builds still fails? Re: [opencv] #3714 bug fix (#3440) There is wrong target branch for merge.
|
|
Target branch is right now. Last problem is: This usually means that someone recently updated same code. And your patch can't be applied automatically. You need to update your code (look for "git rebase"). Commands are similar to:
|
|
Thank Alex, I got it all fix now |
|
@HelenWong, you still need to squash your commits. |
|
Hi ilya, thanks for letting me know. I have already followed the squash commands as suggested by this link: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html |
Guys, why are we bringing back the old CV_ variables in the 2.4 documentation. Since 2.4.8 the code is supporting the new parameters with the CV_ part in front of it and the documentation was changed to make people use the new variables. The CV_ ones are disappearing in the near feature right with the 3.0 release? Certainly when the source base code already has these parameters! https://github.com/Itseez/opencv/search?utf8=%E2%9C%93&q=IMREAD_UNCHANGED So I think that is a very stupid change to do ... just my 2 cents! As to the squash, just use |
|
commits are squashed already. Thanks for everyone's help. |
|
The reason my file contains the old CV_variables because my changes are based on 2.4.9 branch |
|
Thanks for the changes. But please pull in the latest 2.4 branch, apply your changes there and then make a new PR. Then the variable change should not happen and your PR will be fine. |
|
I actually just changed those variables manually and I am not sure if this fix the problem. |
For Bug #3714, user use the imshow() function without calling namedWindow() properly, because user did not know the implicit rule for imshow(). (i.e. without calling namedWindow implied calling namedWindow( ,CV__WINDOW_AUTOSIZE). Improve the Display Image Tutorial to educate the user for such implied rule. Put a note on documentation for Bug#3714 Revise the documentation regarding to imshow() function to better educate the user the implicit rule. (i.e. without creating the window before the imshow() function is the same as creating AUTOSIZE window)
|
Since it is a fix of existing 'stable' functionality this should definately go in the 2.4 branch. The reason of the variables was indeed pulling 2.4 towards master branch and we do not want that :) So please make a new PR, reference this one and close this one down then. |
…trix calculation error
…trix calculation error
Changing both the documentation and the tutorial to better educate the users regarding to the implicit rule in imshow() function. (i.e. without creating the window before the imshow() function is the same as creating AUTOSIZE window)
For bug information, please check this link:http://code.opencv.org/issues/3714