#3714 bug fix #3440
Closed
#3714 bug fix #3440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was triggered by Buildroot autobuilders [1,2], causing this kind of failures [3,4]: [ 14%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/system.cpp.o /home/test/autobuild/instance-0/output/build/opencv-2.4.10/modules/core/src/system.cpp: In function '(static initializers for /home/test/autobuild/instance-0/output/build/opencv-2.4.10/modules/core/src/system.cpp)': /home/test/autobuild/instance-0/output/build/opencv-2.4.10/modules/core/src/system.cpp:280:10: error: inconsistent operand constraints in an 'asm' make[3]: *** [modules/core/CMakeFiles/opencv_core.dir/src/system.cpp.o] Error 1 [1] http://buildroot.org/ [2] http://autobuild.buildroot.org/ [3] http://autobuild.buildroot.org/?reason=opencv-2.4.10 [4] http://autobuild.buildroot.org/results/483/4838285b25d6293a5cf0bb9eadd5040a7c75d766/build-end.log Signed-off-by: Samuel Martin <s.martin49@gmail.com>
…during destruction ContextImpl::currentContext contains a reference to one of the DeviceInfoImpl objects from: static std::vector<DeviceInfoImpl> global_devices; ContextImpl::currentContext is destroyed in the destructor for the statically defined object __module, and relies on its DeviceInfoImpl reference to query some hardware features while being destroyed. This means that we need to ensure that the global_devices vector is destroyed affter __module, otherwise ContextImpl::currentContext's DeviceInfoImpl reference will no longer be valid when __module is destroyed. Since these variables are all confined to a single compilation unit, they will be destruct from bottom to top, so we need to make sure that __module is the bottom definition so it can be destroyed first.
Project Proposal
For Bug #3714, user use the imshow() function without calling namedWindow() properly, because user did not know the implicit rule for imshow(). (i.e. without calling namedWindow implied calling namedWindow( ,CV__WINDOW_AUTOSIZE). Improve the Display Image Tutorial to educate the user for such implied rule.
This reverts commit 6e3d63f.
This reverts commit 99b3b43.
Revise the documentation regarding to imshow() function to better educate the user the implicit rule. (i.e. without creating the window before the imshow() function is the same as creating AUTOSIZE window)
Contributor
Author
|
I don't know why there is merge conflicts and why the build fails? |
Member
|
There is wrong target branch for merge.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing both the documentation and the tutorial to better educate the users regarding to the implicit rule in imshow() function. (i.e. without creating the window before the imshow() function is the same as creating AUTOSIZE window)
For bug information, please check this link:http://code.opencv.org/issues/3714