Skip to content

Fix for Bug#3757: All dimension values are 0 after release is called#2891

Merged
opencv-pushbot merged 1 commit intoopencv:2.4from
nisargthakkar:dims_zero_on_release
Jun 25, 2014
Merged

Fix for Bug#3757: All dimension values are 0 after release is called#2891
opencv-pushbot merged 1 commit intoopencv:2.4from
nisargthakkar:dims_zero_on_release

Conversation

@nisargthakkar
Copy link
Copy Markdown
Contributor

Fix for Bug #3757.
Made all dimensions 0 after release is called on a Mat object

@nisargthakkar nisargthakkar mentioned this pull request Jun 23, 2014
@SpecLad
Copy link
Copy Markdown

SpecLad commented Jun 23, 2014

👍

@SpecLad SpecLad self-assigned this Jun 23, 2014
@nisargthakkar
Copy link
Copy Markdown
Contributor Author

The buildbot is showing unsuccessful builds. Should I change anything?

@SpecLad
Copy link
Copy Markdown

SpecLad commented Jun 24, 2014

No, someone else broke it. Just wait until #2889 is merged.

@nisargthakkar
Copy link
Copy Markdown
Contributor Author

How to run the buildbot again? Do i have to recommit?

@SpecLad
Copy link
Copy Markdown

SpecLad commented Jun 24, 2014

Don't do anything. I'll do it myself.

@ilya-lavrenov
Copy link
Copy Markdown
Contributor

@nisargthakkar, @SpecLad, don't you think we should also add cols = rows = dims = flags = 0?

@nisargthakkar
Copy link
Copy Markdown
Contributor Author

yes, i agree. We should make that change

@SpecLad
Copy link
Copy Markdown

SpecLad commented Jun 24, 2014

cols and rows are the same as size[0] and size[1]. I think dims is used to avoid reallocating the size array on .create() if the new number of dimensions is the same as the old one (although the logic is convoluted enough that I can't say for sure that's the case), and I think people might be relying on it not changing, so I think we should leave it alone. As for flags... maybe. I'll have to check whether that affects anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants