Skip to content

Fisheye camera model for calibration and stereo rectification#2889

Merged
opencv-pushbot merged 1 commit intoopencv:2.4from
Ilya-Krylov:fisheye
Jun 24, 2014
Merged

Fisheye camera model for calibration and stereo rectification#2889
opencv-pushbot merged 1 commit intoopencv:2.4from
Ilya-Krylov:fisheye

Conversation

@Ilya-Krylov
Copy link
Copy Markdown

@Ilya-Krylov Ilya-Krylov commented Jun 23, 2014

Fixed failing test on windows x64 and build issues on android
http://master.ocv/buildbot/builders/precommit_windows64/builds/160/steps/test_calib3d/logs/stdio

@Ilya-Krylov
Copy link
Copy Markdown
Author

Ilya-Krylov commented Jun 23, 2014

@vpisarev , please review

@SpecLad SpecLad mentioned this pull request Jun 24, 2014
Merged
@vpisarev
Copy link
Copy Markdown
Contributor

vpisarev commented Jun 24, 2014

👍

@opencv-pushbot opencv-pushbot merged commit 84bb77e into opencv:2.4 Jun 24, 2014
vpisarev added a commit that referenced this pull request Jun 24, 2014
@vpisarev
Merge pull request #2889 from Ilya-Krylov:fisheye
fb8fa3f
@SpecLad SpecLad mentioned this pull request Jul 8, 2014
Merged
@rgkoo
Copy link
Copy Markdown

rgkoo commented Aug 28, 2014

@Ilya-Krylov
Sorry,I don't know other efficient way to comunicate with you,so write in this place.
When I read the docs of opencv3.0,I found some functions about fisheye and fisheye model developed by you,they are great.
I want to ask you which papers you have referenced about the fisheye model.
Thanks.

@Ilya-Krylov
Copy link
Copy Markdown
Author

Ilya-Krylov commented Sep 1, 2014

@rgkoo ,
Hi, functions about fisheye were ported from Camera Calibration Toolbox for Matlab of Jean-Yves Bouguet. You could found references there.

@rgkoo
Copy link
Copy Markdown

rgkoo commented Sep 1, 2014

@Ilya-Krylov Very thank.

@ShaowuYang
Copy link
Copy Markdown

ShaowuYang commented Dec 28, 2016

@Ilya-Krylov
Hi, if the camera model in Jean-Yves Bouguet's work is used, I would assume that the model and calibration method in Opencv does not fit to fisheye lens with FOV up to 180 degrees. Is that true?
Thanks a lot.

@rfn123
Copy link
Copy Markdown

rfn123 commented Jul 10, 2017 •
edited
Loading

@Ilya-Krylov Hi, first of all, thank you for your contribution of the fisheye model, I am using it now and it works very well! I now want to understand the maths behind it, and I have a question:
when you compute the angle of the incoming ray (e.g. in line 136), why did you use the normalized version double theta = atan(r); ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vpisarev vpisarev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Ilya-Krylov @vpisarev @rgkoo @ShaowuYang @rfn123 @opencv-pushbot