Skip to content

docs(features2d): document getBlobContours and collectContours in SimpleBlobDetector#28275

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
Shruti192903:docs/simpleblobdetector-api
Dec 23, 2025
Merged

docs(features2d): document getBlobContours and collectContours in SimpleBlobDetector#28275
asmorkalov merged 2 commits intoopencv:4.xfrom
Shruti192903:docs/simpleblobdetector-api

Conversation

@Shruti192903
Copy link
Copy Markdown
Contributor

@Shruti192903 Shruti192903 commented Dec 22, 2025

Description: This PR adds missing Doxygen documentation for the getBlobContours() method and the collectContours parameter in SimpleBlobDetector. These features were previously undocumented, making the contour collection functionality difficult for users to discover and use correctly.

Changes:
Added a @brief and detailed note for SimpleBlobDetector::Params::collectContours.
Added documentation for SimpleBlobDetector::getBlobContours(), including a @note regarding the required parameter setup.

Testing:
Verified the documentation build locally on macOS using ninja opencv_docs.
Confirmed the generated HTML displays the descriptions and cross-references accurately.

Partially fixes: #25904
Related PR that adds method: #21942

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work.
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.13.0 milestone Dec 23, 2025
@asmorkalov asmorkalov added the category: documentation Documentation fix or update label Dec 23, 2025
@asmorkalov asmorkalov self-assigned this Dec 23, 2025
@asmorkalov
Copy link
Copy Markdown
Contributor

CI warnings:

modules/features2d/include/opencv2/features2d.hpp:772: trailing whitespace.
+      /** @brief Flag to enable contour collection. 
modules/features2d/include/opencv2/features2d.hpp:773: trailing whitespace.
+      If set to true, the detector will store the contours of the detected blobs in memory, 
modules/features2d/include/opencv2/features2d.hpp:774: trailing whitespace.
+      which can be retrieved after the detect() call using getBlobContours(). 
modules/features2d/include/opencv2/features2d.hpp:792: trailing whitespace.
+  
modules/features2d/include/opencv2/features2d.hpp:793: trailing whitespace.
+  @note The @ref Params::collectContours parameter must be set to true before calling

@asmorkalov asmorkalov self-requested a review December 23, 2025 07:29
@Shruti192903
Copy link
Copy Markdown
Contributor Author

I have removed the trailing whitespaces as requested and verified the file locally using git diff --check. Ready for a final review once the CI checks pass. Thank you!

@asmorkalov asmorkalov merged commit 7e66c05 into opencv:4.x Dec 23, 2025
24 of 26 checks passed
FoxHelms pushed a commit to FoxHelms/opencv that referenced this pull request Dec 23, 2025
…ctor-api

docs(features2d): document getBlobContours and collectContours in SimpleBlobDetector opencv#28275

Description: This PR adds missing Doxygen documentation for the getBlobContours() method and the collectContours parameter in SimpleBlobDetector. These features were previously undocumented, making the contour collection functionality difficult for users to discover and use correctly.

Changes:
Added a @brief and detailed note for SimpleBlobDetector::Params::collectContours.
Added documentation for SimpleBlobDetector::getBlobContours(), including a @note regarding the required parameter setup.

Testing:
Verified the documentation build locally on macOS using ninja opencv_docs.
Confirmed the generated HTML displays the descriptions and cross-references accurately.

Partially fixes: opencv#25904
Related PR that adds method: opencv#21942

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work.
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
@asmorkalov asmorkalov mentioned this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: documentation Documentation fix or update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SimpleBlobDetector lacks documentation

2 participants