added blob contours to blob detector#21942
Merged
alalek merged 3 commits intoopencv:4.xfrom Oct 7, 2022
Merged
Conversation
49e9c75 to
539efc5
Compare
b36fa69 to
bf284a9
Compare
139ebd5 to
cd46489
Compare
Contributor
|
@pglotov, thank you for the contribution! |
vpisarev
reviewed
Jun 7, 2022
Contributor
Author
|
makes sense, made changes |
5469b78 to
de097f5
Compare
vpisarev
reviewed
Jun 17, 2022
Contributor
|
@pglotov, thank you! I have just one more comment – see above. Other than that, the patch is ready for integration. |
2351b8b to
8586426
Compare
3de47e5 to
76f7efb
Compare
Contributor
|
@alalek Could you add an exception to abi-complience-checker for the new fields and methods. |
vpisarev
approved these changes
Sep 19, 2022
alalek
reviewed
Sep 26, 2022
| CV_WRAP static Ptr<SimpleBlobDetector> | ||
| create(const SimpleBlobDetector::Params ¶meters = SimpleBlobDetector::Params()); | ||
| CV_WRAP virtual String getDefaultName() const CV_OVERRIDE; | ||
| CV_WRAP virtual const std::vector<std::vector<Point> >& getBlobContours() const = 0; |
Member
There was a problem hiding this comment.
"Source API" compatibility doesn't allow to add new virtual pure methods.
Do we really want to violate that and bypass checker?
- 4.x: implementation with
CV_Error(not implemented)should be used instead. - 5.x: pure method patch should be used
Contributor
Author
There was a problem hiding this comment.
I initially wanted to merged this into master, not a particular release. Do you think it makes sense to have two PRs for both branches?
Contributor
There was a problem hiding this comment.
@alalek I added stup implementation with CV_Error.
alalek
reviewed
Sep 26, 2022
…resume source API compatibility.
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
added blob contours to blob detector * added blob contours * Fixed Java regression test after new parameter addition to SimpleBlobDetector. * Added stub implementation of SimpleBlobDetector::getBlobContours to presume source API compatibility.
6 tasks
asmorkalov
pushed a commit
that referenced
this pull request
Dec 23, 2025
docs(features2d): document getBlobContours and collectContours in SimpleBlobDetector #28275 Description: This PR adds missing Doxygen documentation for the getBlobContours() method and the collectContours parameter in SimpleBlobDetector. These features were previously undocumented, making the contour collection functionality difficult for users to discover and use correctly. Changes: Added a @brief and detailed note for SimpleBlobDetector::Params::collectContours. Added documentation for SimpleBlobDetector::getBlobContours(), including a @note regarding the required parameter setup. Testing: Verified the documentation build locally on macOS using ninja opencv_docs. Confirmed the generated HTML displays the descriptions and cross-references accurately. Partially fixes: #25904 Related PR that adds method: #21942 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work. - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
FoxHelms
pushed a commit
to FoxHelms/opencv
that referenced
this pull request
Dec 23, 2025
…ctor-api docs(features2d): document getBlobContours and collectContours in SimpleBlobDetector opencv#28275 Description: This PR adds missing Doxygen documentation for the getBlobContours() method and the collectContours parameter in SimpleBlobDetector. These features were previously undocumented, making the contour collection functionality difficult for users to discover and use correctly. Changes: Added a @brief and detailed note for SimpleBlobDetector::Params::collectContours. Added documentation for SimpleBlobDetector::getBlobContours(), including a @note regarding the required parameter setup. Testing: Verified the documentation build locally on macOS using ninja opencv_docs. Confirmed the generated HTML displays the descriptions and cross-references accurately. Partially fixes: opencv#25904 Related PR that adds method: opencv#21942 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work. - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option to collect blob contours during blob detection (SimpleBlobDetector).
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.