Skip to content

solvePnPRansac implementation for Fisheye camera model#26669

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
GouMinghao:4.x
Jan 24, 2025
Merged

solvePnPRansac implementation for Fisheye camera model#26669
asmorkalov merged 2 commits intoopencv:4.xfrom
GouMinghao:4.x

Conversation

@GouMinghao
Copy link
Copy Markdown
Contributor

@GouMinghao GouMinghao commented Dec 24, 2024

Related: #25028

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@GouMinghao
Copy link
Copy Markdown
Contributor Author

@asmorkalov @vpisarev
First of all, Merry Christmas!
Hi, this is the first time that I am tring to contribute to opencv, Could you have a look on this PR and give me some advice.
I just implement solvePnPRansac similar to #25028.
Unit test is added and everything seems to be correct.
Thanks a lot.

@GouMinghao
Copy link
Copy Markdown
Contributor Author

@asmorkalov There are some errors in the CI but seem not to be related to this PR, could you have a look on this?

@asmorkalov asmorkalov self-requested a review January 6, 2025 08:25
@GouMinghao
Copy link
Copy Markdown
Contributor Author

@asmorkalov Thank you for your review. The related problems have been addressed.
You may check it again.

@asmorkalov asmorkalov self-assigned this Jan 24, 2025
@asmorkalov asmorkalov added this to the 4.12.0 milestone Jan 24, 2025
@asmorkalov asmorkalov merged commit 9bb01e7 into opencv:4.x Jan 24, 2025
@asmorkalov asmorkalov mentioned this pull request Feb 19, 2025
NanQin555 pushed a commit to NanQin555/opencv that referenced this pull request Feb 24, 2025
solvePnPRansac implementation for Fisheye camera model opencv#26669

Related: opencv#25028

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants