FastCV-based HAL for OpenCV acceleration 2ndpost-3#26621
Merged
asmorkalov merged 4 commits intoopencv:4.xfrom Dec 19, 2024
Merged
FastCV-based HAL for OpenCV acceleration 2ndpost-3#26621asmorkalov merged 4 commits intoopencv:4.xfrom
asmorkalov merged 4 commits intoopencv:4.xfrom
Conversation
savuor
reviewed
Dec 13, 2024
asmorkalov
approved these changes
Dec 16, 2024
Contributor
|
@quic-apreetam The first part has been merged. Please rebase your patch and fix conflicts. The patch provides Canny only. I expect, the PR should be independent from post-2. |
Contributor
Author
hi @asmorkalov, @adsha-quic will have to rebase #26619 again if I resolve the conflict now. Once #26619 is merged, I will resolve the conflict. |
6 tasks
Contributor
|
The second part has been merged. Please rebase the PR on top of 4.x. |
ecc86a5 to
ee15179
Compare
Contributor
Author
hi @asmorkalov rebased on top of 4.x and enabled fastcv by default. |
asmorkalov
reviewed
Dec 19, 2024
Contributor
|
The PR passed Android CI. Please revert root cmake changes and I'll merge it. |
This reverts commit ee15179.
Contributor
Author
hi @asmorkalov reverted the root cmake change. thanks |
Merged
shyama7004
pushed a commit
to shyama7004/opencv
that referenced
this pull request
Jan 20, 2025
FastCV-based HAL for OpenCV acceleration 2ndpost-3 opencv#26621 ### Detailed description: - Add cv_hal_canny for Canny API Requires binary from [opencv/opencv_3rdparty#90](opencv/opencv_3rdparty#90) Depends on: [opencv#26617](opencv#26617) Depends on: [opencv#26619](opencv#26619) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
NanQin555
pushed a commit
to NanQin555/opencv
that referenced
this pull request
Feb 24, 2025
FastCV-based HAL for OpenCV acceleration 2ndpost-3 opencv#26621 ### Detailed description: - Add cv_hal_canny for Canny API Requires binary from [opencv/opencv_3rdparty#90](opencv/opencv_3rdparty#90) Depends on: [opencv#26617](opencv#26617) Depends on: [opencv#26619](opencv#26619) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description:
Requires binary from opencv/opencv_3rdparty#90
Depends on: opencv/opencv#26617
Depends on: opencv/opencv#26619
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.