FastCV-based HAL for OpenCV acceleration 2ndpost-2 by adsha-quic · Pull Request #26619 · opencv/opencv

adsha-quic · 2024-12-12T10:24:35Z

Detailed description:

Add support for multiply 8u, 16s and 32f
Add support for cv_hal_pyrdown 8u
Add support for cv_hal_cvtBGRtoHSV and cv_hal_cvtBGRtoYUVApprox 8u

Requires binary from opencv/opencv_3rdparty#90
Depends on: opencv/opencv#26617

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
The PR is proposed to the proper branch
There is a reference to the original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

3rdparty/fastcv/src/fastcv_hal_imgproc.cpp

asmorkalov · 2024-12-18T06:35:51Z

@adsha-quic I merged the first part. Please rebase and fix conflicts.

adsha-quic · 2024-12-18T10:28:39Z

@adsha-quic I merged the first part. Please rebase and fix conflicts.

Hey
I have rebased the change, also enabled fastcv by default

asmorkalov · 2024-12-18T11:54:37Z

I still see "This branch has conflicts that must be resolved" in PR status.

…cn, pyrDown

…y Rostislav

…sults on LM

adsha-quic · 2024-12-18T13:27:23Z

I still see "This branch has conflicts that must be resolved" in PR status.

Hey
rebased on 4.x

3rdparty/fastcv/include/fastcv_hal_imgproc.hpp

3rdparty/fastcv/src/fastcv_hal_imgproc.cpp

asmorkalov · 2024-12-18T15:36:45Z

3rdparty/fastcv/src/fastcv_hal_imgproc.cpp

+    bool            isFullRange,
+    bool            isHSV)
+{
+    if(width * height > 640 * 480)


Are you sure in sign? Does it work for small sizes only?

Are you sure in sign? Does it work for small sizes only?

Currently yes, we will add more resolutions later on.

3rdparty/fastcv/src/fastcv_hal_imgproc.cpp

asmorkalov

👍 Thanks a lot for the patch! Please revert the changes in root cmake file and I'll merge the patch.

This reverts commit cdcc909.

adsha-quic · 2024-12-19T04:49:04Z

👍 Thanks a lot for the patch! Please revert the changes in root cmake file and I'll merge the patch.

Hey Alex,
done.

FastCV-based HAL for OpenCV acceleration 2ndpost-3 #26621 ### Detailed description: - Add cv_hal_canny for Canny API Requires binary from [opencv/opencv_3rdparty#90](opencv/opencv_3rdparty#90) Depends on: [#26617](#26617) Depends on: [#26619](#26619) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake

FastCV Extension code for OpenCV 2ndpost-2 #3845 ### Description: - Add support for cv::fastcv::calcHist Depends on: [#3844](#3844) Depends on: [opencv/opencv#26619](opencv/opencv#26619) Requires binary from: [opencv/opencv_3rdparty#90](opencv/opencv_3rdparty#90) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake

FastCV-based HAL for OpenCV acceleration 2ndpost-2 opencv#26619 ### Detailed description: - Add support for multiply 8u, 16s and 32f - Add support for cv_hal_pyrdown 8u - Add support for cv_hal_cvtBGRtoHSV and cv_hal_cvtBGRtoYUVApprox 8u Requires binary from [opencv/opencv_3rdparty#90](opencv/opencv_3rdparty#90) Depends on: [opencv#26617](opencv#26617) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake

FastCV-based HAL for OpenCV acceleration 2ndpost-3 opencv#26621 ### Detailed description: - Add cv_hal_canny for Canny API Requires binary from [opencv/opencv_3rdparty#90](opencv/opencv_3rdparty#90) Depends on: [opencv#26617](opencv#26617) Depends on: [opencv#26619](opencv#26619) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake

FastCV-based HAL for OpenCV acceleration 2ndpost-2 opencv#26619 ### Detailed description: - Add support for multiply 8u, 16s and 32f - Add support for cv_hal_pyrdown 8u - Add support for cv_hal_cvtBGRtoHSV and cv_hal_cvtBGRtoYUVApprox 8u Requires binary from [opencv/opencv_3rdparty#90](opencv/opencv_3rdparty#90) Depends on: [opencv#26617](opencv#26617) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake

FastCV-based HAL for OpenCV acceleration 2ndpost-3 opencv#26621 ### Detailed description: - Add cv_hal_canny for Canny API Requires binary from [opencv/opencv_3rdparty#90](opencv/opencv_3rdparty#90) Depends on: [opencv#26617](opencv#26617) Depends on: [opencv#26619](opencv#26619) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake

quic-apreetam mentioned this pull request Dec 12, 2024

FastCV-based HAL for OpenCV acceleration 2ndpost-3 #26621

Merged

6 tasks

adsha-quic mentioned this pull request Dec 12, 2024

FastCV Extension code for OpenCV 2ndpost-2 opencv/opencv_contrib#3845

Merged

6 tasks

asmorkalov added optimization platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc category: 3rdparty labels Dec 13, 2024

asmorkalov self-requested a review December 13, 2024 07:46

asmorkalov self-assigned this Dec 13, 2024

asmorkalov added this to the 4.11.0 milestone Dec 13, 2024

asmorkalov reviewed Dec 16, 2024

View reviewed changes

3rdparty/fastcv/src/fastcv_hal_imgproc.cpp Show resolved Hide resolved

3rdparty/fastcv/src/fastcv_hal_imgproc.cpp Show resolved Hide resolved

adsha-quic force-pushed the adsha_2ndPost branch from cdb76cc to 320e1de Compare December 17, 2024 12:12

adsha-quic force-pushed the adsha_2ndPost branch from 320e1de to 3bd0b70 Compare December 18, 2024 10:27

adsha-quic and others added 10 commits December 18, 2024 18:54

Adding HALs for gemm, multiply 8u, 16s, 32f, split 2 cn, merge 2 3 4 …

9a3bc0d

…cn, pyrDown

Adding HALS for cvtColor BGR2YCbCr and BGR2HSV_FULL

9024008

Removing height==1 stride checks in multiply HAL as per suggestions b…

d96c507

…y Rostislav

Removing stride multiple of 4 checks in gemm HAL

457a48d

Adding min resolution check for split and merge based on profiling re…

1aa8775

…sults on LM

Removing merge and split from HAL, will add to extn

1818ff0

Temp Removing gemm HAL

9125064

Adding float cmp changes based on Xue's macro

2ec4be9

Removing canny added by mistake

68f2518

Enable fastcv by default

cdcc909

adsha-quic force-pushed the adsha_2ndPost branch from 3bd0b70 to cdcc909 Compare December 18, 2024 13:26

asmorkalov reviewed Dec 18, 2024

View reviewed changes

Adding fixes in pyrDown hal and cvtColor hal suggested by Alexander

9cf1e64

asmorkalov approved these changes Dec 18, 2024

View reviewed changes

Revert "Enable fastcv by default"

0b9d936

This reverts commit cdcc909.

asmorkalov merged commit 59f762b into opencv:4.x Dec 19, 2024

asmorkalov mentioned this pull request Jan 15, 2025

5.x merge 4.x #26768

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

FastCV-based HAL for OpenCV acceleration 2ndpost-2#26619

FastCV-based HAL for OpenCV acceleration 2ndpost-2#26619
asmorkalov merged 12 commits intoopencv:4.xfrom
CodeLinaro:adsha_2ndPost

adsha-quic commented Dec 12, 2024

Uh oh!

Uh oh!

Uh oh!

asmorkalov commented Dec 18, 2024

Uh oh!

adsha-quic commented Dec 18, 2024

Uh oh!

asmorkalov commented Dec 18, 2024

Uh oh!

adsha-quic commented Dec 18, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asmorkalov Dec 18, 2024

Uh oh!

adsha-quic Dec 18, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asmorkalov left a comment

Uh oh!

adsha-quic commented Dec 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

adsha-quic commented Dec 12, 2024

Detailed description:

Pull Request Readiness Checklist

Uh oh!

Uh oh!

Uh oh!

asmorkalov commented Dec 18, 2024

Uh oh!

adsha-quic commented Dec 18, 2024

Uh oh!

asmorkalov commented Dec 18, 2024

Uh oh!

adsha-quic commented Dec 18, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asmorkalov Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

adsha-quic Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asmorkalov left a comment

Choose a reason for hiding this comment

Uh oh!

adsha-quic commented Dec 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants