Skip to content

Split Javascript white-list to support contrib modules#25986

Merged
asmorkalov merged 5 commits intoopencv:4.xfrom
asmorkalov:as/js_for_contrib
Aug 23, 2024
Merged

Split Javascript white-list to support contrib modules#25986
asmorkalov merged 5 commits intoopencv:4.xfrom
asmorkalov:as/js_for_contrib

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Aug 2, 2024 •
edited by opencv-alalek
Loading

Single whitelist converted to several per-module json files. They are concatenated automatically and can be overriden by user config.

Related to #25656

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
Xbuild_image:Docs=docs-js
build_image:Custom=javascript
build_image:Docs=docs-js:22.04-3.1.64
#build_image:Custom=javascript:3.1.64
buildworker:Custom=linux-4
buildworker:Docs=linux-4

@asmorkalov asmorkalov added this to the 4.11.0 milestone Aug 2, 2024
opencv-alalek
opencv-alalek reviewed Aug 2, 2024
View reviewed changes
@opencv-alalek
Copy link
Copy Markdown
Contributor

opencv-alalek commented Aug 9, 2024

Regression in javascript tests (with both legacy and upgraded EMSDK):

Errors:

Module: Photo Test: test_photo
Died on test #1: cv.CalibrateDebevec is not a constructor
    at Object.global.test.QUnit.test (/build/precommit_custom_linux/build/bin/node_modules/node-qunit/lib/child.js:132:17)
    at Object.<anonymous> (/build/precommit_custom_linux/build/bin/test_photo.js:45:7)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
TypeError: cv.CalibrateDebevec is not a constructor
    at Object.<anonymous> (/build/precommit_custom_linux/build/bin/test_photo.js:48:27)

photo's module part is missing.

@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Aug 21, 2024

@opencv-alalek I fixed the namespace issue and added branch with the old python config. Please take a look again.

@asmorkalov asmorkalov merged commit 6c6d5cd into opencv:4.x Aug 23, 2024
This was referenced Aug 27, 2024
Merged
Closed
@asmorkalov asmorkalov mentioned this pull request Sep 13, 2024
Merged
4 tasks
@asmorkalov asmorkalov mentioned this pull request Sep 24, 2024
Merged
6 tasks
thewoz pushed a commit to CobbsLab/OPENCV that referenced this pull request Feb 13, 2025
@asmorkalov @thewoz
Merge pull request opencv#25986 from asmorkalov:as/js_for_contrib
a28d923 
Split Javascript white-list to support contrib modules opencv#25986

Single whitelist converted to several per-module json files. They are concatenated automatically and can be overriden by user config.

Related to opencv#25656

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
@opencv-alalek opencv-alalek mentioned this pull request Oct 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek opencv-alalek approved these changes

@dkurt dkurt Awaiting requested review from dkurt

Assignees

@opencv-alalek opencv-alalek

Labels

category: javascript (js) feature

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asmorkalov @opencv-alalek