added ximgproc edgedrawing to opencvjs, #25656
added ximgproc edgedrawing to opencvjs, #25656geroldmeisinger wants to merge 1 commit intoopencv:4.xfrom
Conversation
…om function which returns a Ptr<class>
|
this pull request also requires a change in contrib:
|
opencv-alalek
left a comment
There was a problem hiding this comment.
Main repo should not know specific detail of opencv_contrib.
Integration should be done through modules/<name>/misc/javascript instead.
| white_list = makeWhiteList([core, imgproc, objdetect, video, dnn, features2d, photo, calib3d]) | ||
| ximgproc = { '': ['createEdgeDrawing'], 'ximgproc_EdgeDrawing': ["setParams", "detectEdges", "getEdgeImage"], 'ximgproc_EdgeDrawing_Params': ["Params", "PFmode"] } | ||
|
|
||
| white_list = makeWhiteList([core, imgproc, objdetect, video, dnn, features2d, photo, calib3d, ximgproc]) |
There was a problem hiding this comment.
This is not the right place for opencv_contrib modules details.
There is no JS wrapper enabled for ximgproc: https://github.com/opencv/opencv_contrib/blob/baaeb68b3d6b557536f95b527c0dd87c8f1ce80d/modules/ximgproc/CMakeLists.txt#L2
There was a problem hiding this comment.
i followed the example of opencv_contrib aruco which is also defined in opencv/platforms/js/opencv_js.config.py. there is no javascript directory for any module.
Split Javascript white-list to support contrib modules #25986 Single whitelist converted to several per-module json files. They are concatenated automatically and can be overriden by user config. Related to #25656 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
|
@geroldmeisinger I split JS whitelist file by modules in #25986. Now You can place contrib related part to contrib repo. |
Split Javascript white-list to support contrib modules opencv#25986 Single whitelist converted to several per-module json files. They are concatenated automatically and can be overriden by user config. Related to opencv#25656 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
|
Replaced by #27828 and opencv/opencv_contrib#4007 |
fixed external constructor from function which returns a Ptr
The problem was that
Ptr< EdgeDrawing > createEdgeDrawing ()getsbase_class_name="EdgeDrawing"where theself.classesare added with namespace prefixedximgproc_EdgeDrawing.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.