Conversation
See microsoft/vcpkg#33443 for some build context when using `vcpkg install opencv4:wasm32-emscripten`.
@opencv-alalek Any comments regarding this^^? |
|
@opencv-alalek I've gone ahead and removed Line 11, Additionally, for people looking for Emscripten 3.X, the fix is involved; I'm working on it currently, but that will be another PR. |
trailing whitespace
|
FYI, Including of |
|
I just checked current OpenCV 4.x with emscripten 3.1.61 (latest) with Ubuntu 24.04. Compilation works well. |
|
The original ticket in MS tracker has reference to OpenCV 4.7.0, not fresh release. I close the PR. Please submit ticket/PR with |
|
I believe this should be re-opened and merged:
@asmorkalov since However, @opencv-alalek Are we saying that OpenCV >= 4.X officially supports Emscripten 3.X, and that should be preferred with OpenCV >= 4.9? If that is the case, the documentation on https://docs.opencv.org/4.10.0/d4/da1/tutorial_js_setup.html needs to be updated
Support for all versions of OpenCV 4.X and Emscripten >= 2.X would need to have the include wrapped in a |
|
@asmorkalov @opencv-alalek please consider re-opening this PR ^^ |
|
@asmorkalov could you please trigger a Action run configuration 27949090047 |
|
@gblikas I propose uncomment |
@asmorkalov I've gone ahead and uncommented the |
|
@asmorkalov Apologies, I'll go ahead and remove whitespaces; it's so much easier to edit directly in browser. May I petition for a bot that removes trailing whitespaces, in addition to the |
trailing whitespace.
|
@asmorkalov done* |
|
CI is still broken for the simd configuration: https://pullrequest.opencv.org/buildbot/builders/precommit_custom_linux/builds/100478/steps/build/logs/stdio |
@asmorkalov Not related to my changes, unless and version 19.0.0 doesn't make sense... should be like I've gone ahead and synced forks, as it looks like I was a few behind. If the sync doesn't resolve the issue, the issue has been present for quite some time and not properly addressed. |
|
Added to the "init" step of JS builder: |
Still should not have effected the failed build @asmorkalov . Also, @alekcac so we are already of version 3.X of Emscripten? |
No. They are experimental builders (added to this PR). |
So, the build issue @asmorkalov was talking about was a reflection of the code I pushed, or the result of an experimental build? |
|
@opencv-alalek @asmorkalov bump* |
Update intrin_wasm.hpp opencv#25909 See microsoft/vcpkg#33443 for some build context when using ```vcpkg install opencv4:wasm32-emscripten``` `__EMSCRIPTEN_major__`, `__EMSCRIPTEN_minor__` and `__EMSCRIPTEN_tiny__` in `emsdk` >= 3.1.4 are in a header, as opposed to command line. We could potentially be more aggressive with how I'm checking this property; let me know if I should make the change. It should also be suggested that `-msimd128` is auto-included in the associated portfile for opencv, but that's a separate issue. Someone let me know if I should also make that change as well. Special thanks to https://github.com/youar for supporting this work; please inform if applying a copyright-header is appropriate attribution. ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
Update intrin_wasm.hpp opencv#25909 See microsoft/vcpkg#33443 for some build context when using ```vcpkg install opencv4:wasm32-emscripten``` `__EMSCRIPTEN_major__`, `__EMSCRIPTEN_minor__` and `__EMSCRIPTEN_tiny__` in `emsdk` >= 3.1.4 are in a header, as opposed to command line. We could potentially be more aggressive with how I'm checking this property; let me know if I should make the change. It should also be suggested that `-msimd128` is auto-included in the associated portfile for opencv, but that's a separate issue. Someone let me know if I should also make that change as well. Special thanks to https://github.com/youar for supporting this work; please inform if applying a copyright-header is appropriate attribution. ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
See microsoft/vcpkg#33443 for some build context when using
vcpkg install opencv4:wasm32-emscripten__EMSCRIPTEN_major__,__EMSCRIPTEN_minor__and__EMSCRIPTEN_tiny__inemsdk>= 3.1.4 are in a header, as opposed to command line.We could potentially be more aggressive with how I'm checking this property; let me know if I should make the change.
It should also be suggested that
-msimd128is auto-included in the associated portfile for opencv, but that's a separate issue. Someone let me know if I should also make that change as well.Special thanks to https://github.com/youar for supporting this work; please inform if applying a copyright-header is appropriate attribution.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.