Skip to content

build fixes for emscripten 3.1.45#24288

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
tailsu:sd/emscripten-3.1.45-fixes
Sep 19, 2023
Merged

build fixes for emscripten 3.1.45#24288
asmorkalov merged 1 commit intoopencv:4.xfrom
tailsu:sd/emscripten-3.1.45-fixes

Conversation

@tailsu
Copy link
Copy Markdown
Contributor

@tailsu tailsu commented Sep 18, 2023

Issue 1: emcc no longer provides implicit defines for the emscripten version, instead there's a separate header that provide them
Issue 2: disabling the objdetect module breaks the js build

Other than these small issues, OpenCV seems to work pretty well with the latest emscripten 👌. Not sure that the maintainers would like to do something with that information, like upgrade or something.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
build_image:Docs=docs-js:18.04
build_image:Custom=javascript
buildworker:Custom=linux-1,linux-4,linux-f1

Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 8f2e664 into opencv:4.x Sep 19, 2023
@asmorkalov asmorkalov self-assigned this Sep 19, 2023
@asmorkalov asmorkalov mentioned this pull request Sep 28, 2023
kalwalt added a commit to webarkit/opencv that referenced this pull request Oct 24, 2023
kalwalt added a commit to webarkit/opencv that referenced this pull request Oct 24, 2023
@opencv-alalek opencv-alalek mentioned this pull request Jul 19, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants