imgcodecs: Add rgb flag for imread and imdecode by zihaomu · Pull Request #25809 · opencv/opencv

zihaomu · 2024-06-24T01:57:36Z

Try to imread images by RGB to save R-B swapping costs.

How to use it?

img_rgb = cv2.imread("PATH", IMREAD_COLOR_RGB) # OpenCV decode the image by RGB format.

TODO

Fix the broken code
Add imread rgb test
Speed test of rgb mode.

Performance test

file name	IMREAD_COLOR	IMREAD_COLOR_RGB
jpg01	284 ms	277 ms
jpg02	376 ms	366 ms
png01	62 ms	60 ms
Png02	97 ms	94 ms

Test with image_test.zip

string img_path = "/Users/mzh/work/data/image_test/png02.png";
int loop = 20;

TickMeter t;

double t0 = 10000;
for (int i = 0; i < loop; i++)
{
    t.reset();
    t.start();
    img_bgr = imread(img_path, IMREAD_COLOR);
    t.stop();

    if (t.getTimeMilli() < t0) t0 = t.getTimeMilli();
}

std::cout<<"bgr time = "<<t0<<std::endl;

t0 = 10000;
for (int i = 0; i < loop; i++)
{
    t.reset();
    t.start();
    img_rgb = imread(img_path, IMREAD_COLOR_RGB);
    t.stop();
    if (t.getTimeMilli() < t0) t0 = t.getTimeMilli();
}
std::cout<<"rgb time = "<<t0<<std::endl;

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
The PR is proposed to the proper branch
There is a reference to the original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

modules/imgcodecs/src/grfmt_jpeg.cpp

modules/imgcodecs/test/test_precomp.hpp

asmorkalov · 2024-06-26T07:45:33Z

I propose to extend existing perf tests with RGB case. Just to be sure that the new mode does not introduce significant degradation.

modules/imgcodecs/test/test_tiff.cpp

asmorkalov · 2024-06-28T06:27:33Z

modules/imgcodecs/test/test_png.cpp

+    img = imread(root + "readwrite/color_palette_alpha.png", IMREAD_COLOR_RGB);
+    ASSERT_FALSE(img.empty());
+    ASSERT_TRUE(img.channels() == 3);
+
+    // pixel is red in RGB
+    EXPECT_EQ(img.at<Vec3b>(0, 0), Vec3b(255, 0, 0));
+    EXPECT_EQ(img.at<Vec3b>(0, 1), Vec3b(255, 0, 0));
+


I propose to add test with RGBA output.

Hi @asmorkalov. For consistency, IMREAD_COLOR_RGB currently converts all RGBA to RGB instead of RGBA output.

modules/imgcodecs/include/opencv2/imgcodecs.hpp

asmorkalov · 2024-07-01T08:59:02Z

Perf results for system wide (Ubuntu 16.04) and own (from 3rdparty) on Jetson-tk1 (ARMv7+NEON):

Geometric mean (ms)

  Name of Test   system-1  own-1    own-1   
                                      vs    
                                   system-1 
                                  (x-factor)
Decode::JPEG     129.067  129.898    0.99   
Decode_rgb::JPEG 129.084  129.561    1.00   
Encode::JPEG     165.524  118.029    1.40   
decode::PNG       82.793  68.338     1.21   
decode_rgb::PNG   79.697  63.584     1.25   
encode::PNG      135.514  116.040    1.17

asmorkalov

👍

…#25809

Restrict opencv version to below 4.11 to keep api stable after opencv/opencv#25809

* syncing util/mask_tools.py * syncing util/image.py * keeping exif unconditionally * syncing components/media.py * syncing components/importer.py * syncing util/meta_file_util.py * moving cli/contexts/project/diff.py to cli/util/compare.py * moving Registry and PluginRegistry to components/registry.py * syncing components/exporter.py * syncing components/hl_ops.py * syncing components/dataset.py * limiting opencv version (due to opencv/opencv#25809) * fixes * upper case extension fix * fixes * always keeping exif info * limiting opencv version * Update src/datumaro/components/media.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * test for reading exif orientation * changelog entry * fixed isort * fixed test * fixed changelog * Update src/datumaro/components/hl_ops/__init__.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * fixing filter examples * hl_ops tests * syncing plugins/data_formats/celeba * syncing plugins/data_formats/cifar.py * setting DETECT_CONFIDENCE for yolo formats * syncing plugins/data_formats/image_dir.py * better detection for yolo classification importer * syncing plugins/data_formats/imagenet.py and plugins/data_formats/imagenet_txt.py * syncing plugins/data_formats/camvid.py * syncing tests/integration/cli/test_detect_format.py * syncing cli/util/project.py * syncing tests/integration/cli/test_filter.py * syncing tests/integration/cli/test_transform.py * yolo streaming exporter * syncing plugins/data_formats/coco * Update src/datumaro/components/media.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * Update src/datumaro/components/media.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * Update src/datumaro/components/media.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * Update tests/unit/test_video.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * Update src/datumaro/components/registry.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * coco find_images_dir do not fail if images folder doe not exist - because cvat needs to be able to export and then import dataset without images * coco find_rootpath do not fail if path does not end with ANNOTATIONS_DIR - because cvat needs it * fixes * fix linters * tests for HLOps.compare * syncing tests/unit/test_image.py * accounting for the new flag in cv2 * syncing components/importer.py * fixes * fixes * fixes * fixes * tests in test_masks.py from upstream * a bit of info on ImageColorChannel.UNCHANGED * fixing wrong merge * removing bad changes * rolling back changes in test * do not recollect subset names in StreamDatasetStorage if transformations do not change subsets * fixes * Refactor with_subset_dirs * Support detect() calls with no return value * Update importer detection confidence * Lower the default confidence * Align default format detection confidence in detector and importer * Clean imports * syncing tests/conftest.py and tests/unit/data_formats/conftest.py * syncing imagenet tests * test new yolo classification detetection behaviour * syncing tests/unit/test_format_detection.py * Apply suggestions from code review Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * fixes * fixes * Apply suggestions from code review Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * small fixes * basic streaming tests for coco and yolo formats * returning previous tests and behaviour for coco * Improve function name * raising error on unknown image id * test coco streaming * test yolo streaming --------- Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com>

add rgb flag

dbee20a

zihaomu linked an issue Jun 24, 2024 that may be closed by this pull request

is that possible to change default image from BGR to RGB at 5.0 version? #23906

Open

asmorkalov reviewed Jun 24, 2024

View reviewed changes

modules/imgcodecs/src/grfmt_jpeg.cpp Show resolved Hide resolved

asmorkalov added feature category: imgcodecs labels Jun 24, 2024

zihaomu added 3 commits June 25, 2024 15:48

fix bug

2509691

add test

71a2837

fix jpeg rgb mode

828bbc5

zihaomu marked this pull request as ready for review June 26, 2024 05:49

asmorkalov reviewed Jun 26, 2024

View reviewed changes

modules/imgcodecs/test/test_precomp.hpp Outdated Show resolved Hide resolved

add perf test

4c072e5

asmorkalov reviewed Jun 28, 2024

View reviewed changes

modules/imgcodecs/test/test_tiff.cpp Show resolved Hide resolved

asmorkalov reviewed Jun 28, 2024

View reviewed changes

modules/imgcodecs/include/opencv2/imgcodecs.hpp Show resolved Hide resolved

asmorkalov changed the title ~~imgcodecs: Add rgb flag~~ imgcodecs: Add rgb flag for imread and imdecode Jul 1, 2024

asmorkalov added this to the 4.11.0 milestone Jul 1, 2024

asmorkalov self-assigned this Jul 2, 2024

rgb tiff pixel test and IMREAD_COLOR_BGR flag

6021844

asmorkalov approved these changes Jul 3, 2024

View reviewed changes

vpisarev self-requested a review July 3, 2024 07:51

vpisarev approved these changes Jul 3, 2024

View reviewed changes

asmorkalov merged commit 934e689 into opencv:4.x Jul 3, 2024

asmorkalov mentioned this pull request Jul 16, 2024

(5.x) Merge 4.x #25915

Merged

Kumataro mentioned this pull request Feb 2, 2025

[Proposal] imread and imdecode RGB data #16665

Open

Eldies added a commit to cvat-ai/datumaro that referenced this pull request Feb 7, 2025

limiting opencv version (due to opencv/opencv#25809)

4bae045

Eldies mentioned this pull request Feb 10, 2025

sync with upstream cvat-ai/datumaro#80

Merged

6 tasks

zhiltsov-max added a commit to cvat-ai/datumaro that referenced this pull request Feb 10, 2025

Restrict opencv version to below 4.11 to keep api after opencv/opencv…

09e0f9c

…#25809

zhiltsov-max mentioned this pull request Feb 10, 2025

Restrict opencv version cvat-ai/datumaro#84

Merged

6 tasks

zhiltsov-max added a commit to cvat-ai/datumaro that referenced this pull request Feb 10, 2025

Restrict opencv version (#84)

61495bc

Restrict opencv version to below 4.11 to keep api stable after opencv/opencv#25809

Avasam mentioned this pull request May 2, 2025

is that possible to change default image from BGR to RGB at 5.0 version? #23906

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

imgcodecs: Add rgb flag for imread and imdecode#25809

imgcodecs: Add rgb flag for imread and imdecode#25809
asmorkalov merged 6 commits intoopencv:4.xfrom
zihaomu:imread_rgb_flag

zihaomu commented Jun 24, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

asmorkalov commented Jun 26, 2024

Uh oh!

Uh oh!

asmorkalov Jun 28, 2024

Uh oh!

zihaomu Jun 28, 2024

Uh oh!

Uh oh!

asmorkalov commented Jul 1, 2024

Uh oh!

asmorkalov left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

zihaomu commented Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use it?

TODO

Performance test

Pull Request Readiness Checklist

Uh oh!

Uh oh!

Uh oh!

asmorkalov commented Jun 26, 2024

Uh oh!

Uh oh!

asmorkalov Jun 28, 2024

Choose a reason for hiding this comment

Uh oh!

zihaomu Jun 28, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

asmorkalov commented Jul 1, 2024

Uh oh!

asmorkalov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zihaomu commented Jun 24, 2024 •

edited

Loading