Skip to content

Restrict opencv version#84

Merged
zhiltsov-max merged 1 commit intodevelopfrom
zm/restrict-opencv-versions
Feb 10, 2025
Merged

Restrict opencv version#84
zhiltsov-max merged 1 commit intodevelopfrom
zm/restrict-opencv-versions

Conversation

@zhiltsov-max
Copy link
Copy Markdown
Collaborator

@zhiltsov-max zhiltsov-max commented Feb 10, 2025

Summary

Dependency for #82

OpenCV added RGB mode for image reading in 4.11. This PR is a temporary workaround, the full solution is to be tracked in #83. Need to add conditional logic for opencv versions before and after 4.11 in cases where cv2.IMREAD_UNCHANGED is used together with cv2.IMREAD_IGNORE_ORIENTATION.

  • Restricted OpenCV version to avoid occasional image API changes

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2025 CVAT.ai Corporation
#
# SPDX-License-Identifier: MIT

@sonarqubecloud
Copy link
Copy Markdown

@zhiltsov-max zhiltsov-max merged commit 61495bc into develop Feb 10, 2025
6 checks passed
@zhiltsov-max zhiltsov-max deleted the zm/restrict-opencv-versions branch February 10, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant