Skip to content

imgcodecs: jpeg: re-support to read CMYK Jpeg#25280

Merged
asmorkalov merged 3 commits intoopencv:4.xfrom
Kumataro:fix25274
Mar 29, 2024
Merged

imgcodecs: jpeg: re-support to read CMYK Jpeg#25280
asmorkalov merged 3 commits intoopencv:4.xfrom
Kumataro:fix25274

Conversation

@Kumataro
Copy link
Copy Markdown
Contributor

@Kumataro Kumataro commented Mar 27, 2024 •
edited by asmorkalov
Loading

Close #25274
OpenCV Extra: opencv/opencv_extra#1163

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Kumataro
Copy link
Copy Markdown
Contributor Author

Kumataro commented Mar 27, 2024

This pactch makes to read a Jpeg data of #25274 correctly.
However this pull request needs to test with other CMYK Jpeg.
Since it seems to take a long time to create the CMYK JPEG, I created a pull request for the patch first.
I will add test after, I'm sorry.

@asmorkalov asmorkalov added this to the 4.10.0 milestone Mar 28, 2024
@asmorkalov asmorkalov self-requested a review March 28, 2024 06:47
@Kumataro Kumataro mentioned this pull request Mar 28, 2024
Merged
@Kumataro Kumataro marked this pull request as ready for review March 28, 2024 10:48
asmorkalov
asmorkalov reviewed Mar 28, 2024
View reviewed changes
@sturkmen72
Copy link
Copy Markdown
Contributor

sturkmen72 commented Mar 28, 2024

@Kumataro i want to discuss something with you.could you send me an e-mail. you can find my e-mail on my github profile. thanks.

@Kumataro
Copy link
Copy Markdown
Contributor Author

Kumataro commented Mar 28, 2024

@sturkmen72 I'm sorry but my email address is not published. Did I miss my failure ?
If it is related with this issue, pleaase could you post it in here ?

asmorkalov
asmorkalov approved these changes Mar 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Mar 29, 2024

@mshabunin @opencv-alalek Any comments?

@asmorkalov asmorkalov self-assigned this Mar 29, 2024
@sturkmen72
Copy link
Copy Markdown
Contributor

sturkmen72 commented Mar 29, 2024

@sturkmen72 I'm sorry but my email address is not published. Did I miss my failure ? If it is related with this issue, pleaase could you post it in here ?

I want to discuss something about imgcodecs module. İt is not related to this issue.

@asmorkalov asmorkalov merged commit 912cf2a into opencv:4.x Mar 29, 2024
@Kumataro
Copy link
Copy Markdown
Contributor Author

Kumataro commented Mar 30, 2024

@asmorkalov Thank you very much ! And I'm sorry that this comparing condition is not correctly exactlly. If norm() return 0, 1 or 2, this test should be passed ideally. However in now implementation it comparing to equal or not only. It is incorrect.

I created #25299 to fix it.

@sturkmen72 (This pull request has been merged, and this topic is not about this issue/pull request. So it is not better to continue here. I want to finish this reply as last.)

I am one of the many contributors, not important person with the authority to decide the direction regarding imgcodecs.

If you have any feature and/or improvement suggestions for imgcodecs, please could you create a ticket in here? If it is intested for me, I'l comment it. Thank you !

@asmorkalov asmorkalov mentioned this pull request Apr 1, 2024
Merged
klatism pushed a commit to klatism/opencv that referenced this pull request May 17, 2024
@Kumataro @klatism
Merge pull request opencv#25280 from Kumataro:fix25274
a81a3f0 
imgcodecs: jpeg: re-support to read CMYK Jpeg opencv#25280

Close opencv#25274 
OpenCV Extra: opencv/opencv_extra#1163

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: imgcodecs

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

Cannot read a CMYK JPEG Image

3 participants

@Kumataro @sturkmen72 @asmorkalov