Skip to content

imgcodecs: jpeg: (test) fix condition to compare rgb and cmyk jpeg#25299

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
Kumataro:add_fix25274
Mar 30, 2024
Merged

imgcodecs: jpeg: (test) fix condition to compare rgb and cmyk jpeg#25299
asmorkalov merged 1 commit intoopencv:4.xfrom
Kumataro:add_fix25274

Conversation

@Kumataro
Copy link
Copy Markdown
Contributor

Comparing condition for rgb- and cmyk-jpeg is incorrect. When norm() returns less than 3, this may make false-positive error.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Kumataro
Copy link
Copy Markdown
Contributor Author

I'm very sorry.
If norm() returns equals or less than threshold(3), they have to be OK. including 0,1,2...

Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov self-assigned this Mar 30, 2024
@asmorkalov asmorkalov merged commit 8c540a5 into opencv:4.x Mar 30, 2024
@asmorkalov asmorkalov mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants