G-API: A quick value-initialization support GMat#25055
Merged
asmorkalov merged 3 commits intoopencv:4.xfrom Mar 6, 2024
Merged
G-API: A quick value-initialization support GMat#25055asmorkalov merged 3 commits intoopencv:4.xfrom
asmorkalov merged 3 commits intoopencv:4.xfrom
Conversation
- Added more tests; - Added a negative test on GComputation with no inputs. Currently explicitly marked as throwing exception (tuned code not to crash in this case). Supporting running graphs like this will be added in a separate PR (a differnt feature)
Contributor
|
@TolyaTalamanov Friendly remider. |
TolyaTalamanov
approved these changes
Mar 6, 2024
| * | ||
| * @param m a cv::Mat buffer to associate with this GMat object. | ||
| */ | ||
| GAPI_WRAP explicit GMat(cv::Mat m); // Value-initialization constructor |
Contributor
There was a problem hiding this comment.
Wondering if it's really working from python, do you plan to add any test to check that, or it will be done later on?
Contributor
Author
There was a problem hiding this comment.
I believe it should work in the same way as for GScalar(cv::Scalar), isn't it?
Contributor
Author
|
Wow, thanks! |
Merged
klatism
pushed a commit
to klatism/opencv
that referenced
this pull request
May 17, 2024
G-API: A quick value-initialization support GMat opencv#25055 This PR enables `GMat` objects to be value-initialized in the same way as it was done for `GScalar`s (and, possibly, other types). - Added some helper methods in backends to distinguish if a certain G-type value initialization is supported or not; - Added tests, including negative. Where it is needed: - Further extension of the OVCV backend (opencv#24379 - will be refreshed soon); - Further experiments with DNN module; - Further experiments with "G-API behind UMat" sort of aggregation. In the current form, PR can be reviewed & merged (@TolyaTalamanov please have a look) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables
GMatobjects to be value-initialized in the same way as it was done forGScalars (and, possibly, other types).Where it is needed:
In the current form, PR can be reviewed & merged (@TolyaTalamanov please have a look)
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.