Include keypoint positions in sorting of points by norm to tie-break#23370
Closed
simonlynen wants to merge 1 commit intoopencv:4.xfrom
Closed
Include keypoint positions in sorting of points by norm to tie-break#23370simonlynen wants to merge 1 commit intoopencv:4.xfrom
simonlynen wants to merge 1 commit intoopencv:4.xfrom
Conversation
This makes LSD deterministic.
Contributor
|
OpenCV 3.4 branch has the same issue. Could you rebase the patch on top of 3.4 branch and re-target it to 3.4. OpenCV team will merge it to 4.x and 5.x during regular merge procedure. |
Contributor
|
Actually, if reproducibility is the only requirement, |
6 tasks
Contributor
Author
|
Moving this to #23388 which uses stable_sort and targets 3.4 |
simonlynen
added a commit
to simonlynen/opencv
that referenced
this pull request
Mar 22, 2023
…ing keypoints prior to region growing This makes LineSegmentDetector deterministic by using stable_sort for ordering points by norm. Without this change the region growing in LSD is non-determinstic and thus the returned lines are changing between invocations. This is a replacement for opencv#23370
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
Jan 4, 2024
…ing keypoints prior to region growing This makes LineSegmentDetector deterministic by using stable_sort for ordering points by norm. Without this change the region growing in LSD is non-determinstic and thus the returned lines are changing between invocations. This is a replacement for opencv#23370
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
…ing keypoints prior to region growing This makes LineSegmentDetector deterministic by using stable_sort for ordering points by norm. Without this change the region growing in LSD is non-determinstic and thus the returned lines are changing between invocations. This is a replacement for opencv#23370
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes LineSegmentDetector deterministic by including keypoint positions as tie-breaker when sorting the seed points by norm. Without this change the region growing in LSD is non-determinstic and thus the returned lines are changing between invocations.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.