Skip to content

Make LineSegmentDetector deterministic by using stable_sort#23388

Merged
asmorkalov merged 1 commit intoopencv:3.4from
simonlynen:patch-2
Mar 23, 2023
Merged

Make LineSegmentDetector deterministic by using stable_sort#23388
asmorkalov merged 1 commit intoopencv:3.4from
simonlynen:patch-2

Conversation

@simonlynen
Copy link
Copy Markdown
Contributor

@simonlynen simonlynen commented Mar 22, 2023 •
edited by asmorkalov
Loading

This makes LineSegmentDetector deterministic by using stable_sort for ordering points by norm. Without this change the region growing in LSD is non-determinstic and thus the returned lines are changing between invocations.

This is a replacement for #23370

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@simonlynen
Make LineSegmentDetector deterministic by using stable_sort for order…
6033599 
…ing keypoints prior to region growing

This makes LineSegmentDetector deterministic by using stable_sort for ordering points by norm. Without this change the region growing in LSD is non-determinstic and thus the returned lines are changing between invocations.

This is a replacement for opencv#23370
@simonlynen simonlynen mentioned this pull request Mar 22, 2023
Closed
6 tasks
@asmorkalov asmorkalov changed the title Make LineSegmentDetector deterministic by using stable_sort for order… Make LineSegmentDetector deterministic by using stable_sort Mar 22, 2023
@asmorkalov asmorkalov requested a review from vpisarev March 22, 2023 06:12
@asmorkalov asmorkalov self-requested a review March 23, 2023 13:17
asmorkalov
asmorkalov approved these changes Mar 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 👍

@asmorkalov asmorkalov assigned asmorkalov and unassigned vpisarev Mar 23, 2023
@asmorkalov asmorkalov added this to the 3.4.20 milestone Mar 23, 2023
@asmorkalov asmorkalov merged commit 1af790e into opencv:3.4 Mar 23, 2023
@simonlynen simonlynen deleted the patch-2 branch March 23, 2023 13:22
@simonlynen
Copy link
Copy Markdown
Contributor Author

simonlynen commented Mar 23, 2023

Thanks for the review

@asmorkalov asmorkalov mentioned this pull request Apr 20, 2023
Merged
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@vpisarev vpisarev Awaiting requested review from vpisarev

Assignees

@asmorkalov asmorkalov

Labels

category: imgproc

Projects

None yet

Milestone

3.4.20

Development

Successfully merging this pull request may close these issues.

3 participants

@simonlynen @asmorkalov @vpisarev