Skip to content

Supress tones of -Wdeprecated-copy warnings#23203

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/xcode_warning_supression
Feb 2, 2023
Merged

Supress tones of -Wdeprecated-copy warnings#23203
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/xcode_warning_supression

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Jan 31, 2023 •
edited
Loading

They jump out of GTest after XCode update to 13.1 on Mac M1.
Merge with opencv/opencv_contrib#3434.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
build_image:Custom=ubuntu-clang:20.04
buildworker:Custom=linux-1,linux-4

alalek
alalek reviewed Jan 31, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is about 3.4 branch? Is it green?

@asmorkalov asmorkalov force-pushed the as/xcode_warning_supression branch 5 times, most recently from 276b87b to 3fd5327 Compare February 1, 2023 10:42
alalek
alalek reviewed Feb 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is failed GHA builder:

(there is no information about used commits SHA, so it is hard to say opencv_contrib version is up-to-date or not)

@alalek
Copy link
Copy Markdown
Member

alalek commented Feb 1, 2023

Added "backport" label, because there are similar issues on 3.4 branch:

@asmorkalov asmorkalov force-pushed the as/xcode_warning_supression branch from 3fd5327 to c855dcc Compare February 2, 2023 10:56
asmorkalov added a commit to asmorkalov/opencv that referenced this pull request Feb 2, 2023
@asmorkalov
Warning supression fix for XCode 13.1 and newer. Backport opencv#23203
132fb28
@asmorkalov asmorkalov changed the title WIP: Try to supress tones of Wdeprecated-copy Supress tones of Wdeprecated-copy Feb 2, 2023
@asmorkalov asmorkalov added port/backport done Label for maintainers. Authors of PR can ignore this and removed backport is needed Label for maintainers. Authors of PR can ignore this labels Feb 2, 2023
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Feb 2, 2023

Backport: #23214

@asmorkalov asmorkalov changed the title Supress tones of Wdeprecated-copy Supress tones of -Wdeprecated-copy warnings Feb 2, 2023
alalek
alalek approved these changes Feb 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you!

@asmorkalov asmorkalov merged commit 206a3fc into opencv:4.x Feb 2, 2023
@alalek alalek mentioned this pull request Feb 3, 2023
Merged
6 tasks
asmorkalov added a commit to asmorkalov/opencv that referenced this pull request Feb 6, 2023
@asmorkalov
Warning supression fix for XCode 13.1 and newer. Backport opencv#23203
9ec6058
asmorkalov added a commit to asmorkalov/opencv that referenced this pull request Feb 6, 2023
@asmorkalov
Warning supression fix for XCode 13.1 and newer. Backport opencv#23203
3d635cb
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
geversonsto pushed a commit to stodev-com-br/opencv that referenced this pull request Jun 3, 2023
@asmorkalov @geversonsto
Warning supression fix for XCode 13.1 and newer. Backport opencv#23203
983ebe5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

No one assigned

Labels

category: build/install platform: ios/osx port/backport done Label for maintainers. Authors of PR can ignore this

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asmorkalov @alalek