Skip to content

-Wunused-but-set-variable warnings fix after XCode update with clang 13.1#3434

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
asmorkalov:as/xcode_warning_supression
Feb 2, 2023
Merged

-Wunused-but-set-variable warnings fix after XCode update with clang 13.1#3434
asmorkalov merged 2 commits intoopencv:4.xfrom
asmorkalov:as/xcode_warning_supression

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Feb 1, 2023

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov mentioned this pull request Feb 1, 2023
Merged
6 tasks
@asmorkalov asmorkalov force-pushed the as/xcode_warning_supression branch from a9d9e36 to f149f26 Compare February 1, 2023 12:01
@alalek
Copy link
Copy Markdown
Member

alalek commented Feb 1, 2023

One more fix is required:

/Users/opencv-cn/GHA-OCV-1/_work/opencv_contrib/opencv_contrib/opencv_contrib/modules/ximgproc/src/brightedges.cpp:82:17: warning: variable 'lines' set but not used [-Wunused-but-set-variable]

@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Feb 2, 2023

@alalek The last warning is tricky. The issue looks like typo in code. Sample result before and after fix:
contast10
contast10_fix

@asmorkalov asmorkalov mentioned this pull request Feb 2, 2023
Merged
6 tasks
@asmorkalov asmorkalov merged commit 04d8492 into opencv:4.x Feb 2, 2023
@asmorkalov asmorkalov mentioned this pull request Feb 6, 2023
Merged
6 tasks
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: build/install category: ximgproc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asmorkalov @alalek