Skip to content

[GSoC] Fix compilation errors and warnings when using MSVC on Windows.#22292

Merged
alalek merged 2 commits intoopencv:4.xfrom
hanliutong:fix
Jul 24, 2022
Merged

[GSoC] Fix compilation errors and warnings when using MSVC on Windows.#22292
alalek merged 2 commits intoopencv:4.xfrom
hanliutong:fix

Conversation

@hanliutong
Copy link
Copy Markdown
Contributor

@hanliutong hanliutong commented Jul 24, 2022 •
edited by alalek
Loading

Related PR: #22278

According to the build issues on Win64 and Win32, I have already modify the code. But since I do not have a device with Windows and MVCS 15, please let the build bot compile the code for further verification.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Win64,win32,Custom Win
build_image:Custom Win=msvs2019

alalek
alalek approved these changes Jul 24, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@alalek alalek merged commit 2bd72af into opencv:4.x Jul 24, 2022
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@hanliutong
Merge pull request opencv#22292 from hanliutong:fix
fddb353 
[GSoC] Fix compilation errors and warnings when using MSVC on Windows.

* Pass reference of the argument.

* Add some cast to suppress warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: build/install platform: win32

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@hanliutong @alalek