[GSoC] Fix compile errors.#22278
Merged
opencv-pushbot merged 2 commits intoopencv:4.xfrom Jul 22, 2022
Merged
Conversation
Member
|
Please take a look on build issues for Win32 build configuration (MSVS 2015): https://pullrequest.opencv.org/buildbot/builders/precommit_windows32/builds/100053 |
Member
|
Win64 (MSVS 2015) build issues are here: https://pullrequest.opencv.org/buildbot/builders/precommit_windows64/builds/100064 |
6 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is going to fix compile errors when 1. all SIMD backend is disabled (aka. using cpp backend) and 2. using RVV backend.
The main modification is using
#if !CV_SIMD_SCALABLEinstead of#if CV_SIMDin the universal intrinsic compatibility layer. And some necessary head file are added to eliminate errors in when all SIMD is disabled.Test with RVV, AVX and cpp backend.
Related PR : [GSoC] New universal intrinsic backend for RVV #22179
Another modification is using
#ifinstead of#ifdefforCV_SIMD128.Because
#ifdef CV_SIMD128will beTruewhenCV_SIMD128is defined as0, which is unexpected and will cause an error in the RVV backend.Related PR : DNN: Accelerating convolution #21910
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.