Merged
Conversation
9263c1a to
1d900f5
Compare
1d900f5 to
a74b3b9
Compare
| CV_CPU_DISPATCH_MODES_ALL); \ | ||
| } | ||
|
|
||
| //CONVERTTO_NOCOEF_SIMD(uchar, uchar) |
| template<typename SRC> | ||
| CV_ALWAYS_INLINE | ||
| typename std::enable_if<std::is_same<SRC, short>::value || | ||
| std::is_same<SRC, ushort>::value, void>::type |
Contributor
There was a problem hiding this comment.
it takes a lot of time on review to expand this conditions in mind. Also i see that these SFINAE repeat again and again
I suggest to introduce MACRO with such condition incapsulation in the way, eventually:
typename std::enable_if<SHORT_OR_USHORT>::type
convertto_simd_nocoeff_impl(...)
<and other functions with similar SFINAE>
...
#define SHORT_OR_USHORT std::is_same<SRC, short>::value || std::is_same<SRC, ushort>::value
etc
f84317e to
dc3c06d
Compare
sivanov-work
approved these changes
Mar 29, 2022
Contributor
sivanov-work
left a comment
There was a problem hiding this comment.
LGTM
Can we apply MACRO in SFINAE approach for other operation dispatchering functions in next PRs?
Member
Author
There is sense to do it in the separate PR in the bounds of a refactoring task. |
Member
Author
|
@alalek Could you please take a look this PR and merge if it looks good for you? |
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
GAPI Fluid: SIMD for ConvertTo. * GAPI Fluid: SIMD for convertto. * Applied comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIMD for ConvertTo
Performance:
FluidConvertToSIMD.xlsx