Merged
Conversation
fc993d8 to
215bf8d
Compare
def4fc1 to
9686f5c
Compare
Contributor
|
@Daniil-Osokin could you take a look and comment? |
3681772 to
3baf334
Compare
asmorkalov
reviewed
Mar 2, 2022
asmorkalov
approved these changes
Mar 3, 2022
alalek
reviewed
Mar 4, 2022
|
|
||
| // CUDA needs input blobs to be rearranged in a specific way, but some transformations | ||
| // in ONNXImporter are destructive, so we keep a copy. | ||
| std::vector<Mat> cudaWorkaround; |
Member
There was a problem hiding this comment.
PR is targeted to 3.4 branch, so there is no CUDA in DNN.
Is there related PR targeted to 4.x?
Member
Author
There was a problem hiding this comment.
Yes, there is. In 4.x branch the contents of this vector will be used, but here its purpose is to tell if we need any onnx-related transformations after forward.
Member
There was a problem hiding this comment.
To avoid confusion we need to rename this field (there is no CUDA code in DNN module for 3.4 branch).
What is about originalBlobs or other more clear name?
|
Math looks ok, so just style commentaries 👍. |
Daniil-Osokin
approved these changes
Mar 14, 2022
Merged
yash112-lang
pushed a commit
to yash112-lang/opencv
that referenced
this pull request
Mar 31, 2022
Fix LSTM support in ONNX * fix LSTM and add peephole support * disable old tests * turn lambdas into functions * more hacks for c++98 * add assertions * slice fixes * backport of cuda-related fixes * address review comments
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #21542
Merge with extra: opencv/opencv_extra#959
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.